Re: [LTP] [PATCH 1/4] libswap: add known swap supported fs check

Li Wang
2024-01-23T13:10:47Z

On Tue, Jan 23, 2024 at 8:31 PM Petr Vorel <pvorel@suse.cz> wrote:

> > On Tue, Jan 23, 2024 at 3:48 PM Petr Vorel <pvorel@suse.cz> wrote:
>
> > > Hi Li,
>
> > > > V3 is here: https://github.com/wangli5665/ltp/commits/libswap-v3
>
> > > I've just scheduled new runs for both Tumbleweed and all SLES versions
> > > (various kernel versions).
>
>
> > Thanks Petr, and sorry for posting to ML so later.
> > I did some polishing work and fixed a few tiny issues based on above V3.
>
> > I'm not sure if the libswap-v3 branch will test well (with tiny issues).
> > So I pushed the latest to my main branch:
> > https://github.com/wangli5665/ltp
> > And, I deployed it with a general test (against RHEL) for the coming
> > release work.
>
> Thanks Li!
> As I wrote to 4th patch [1] there will be v4 needed, but fix should be
> easy.
>

The fix is needed, but it does not belong to my libswap patch set.
Without applying the five patches, swapoff still fails, right?
(it originally caused by the tst_fill_file() but not other thing)

It probably needs to be fixed in a separate patch in following up.

--
Regards,
Li Wang