public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
* [LTP] [PATCH] Fix incorrect tst_brk usage in nfslock01.sh
@ 2024-01-22 12:25 Martin Doucha
  2024-01-22 15:48 ` Petr Vorel
  0 siblings, 1 reply; 2+ messages in thread
From: Martin Doucha @ 2024-01-22 12:25 UTC (permalink / raw)
  To: ltp

Signed-off-by: Martin Doucha <mdoucha@suse.cz>
---

In the previous release, the nfs_lock process failure would skip any
remaining filesystems. After this change, the single filesystem test run
will exit but all remeaining filesystems will be tested.

 testcases/network/nfs/nfslock01/nfslock01.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/testcases/network/nfs/nfslock01/nfslock01.sh b/testcases/network/nfs/nfslock01/nfslock01.sh
index 01d59ce85..1f8c2d755 100755
--- a/testcases/network/nfs/nfslock01/nfslock01.sh
+++ b/testcases/network/nfs/nfslock01/nfslock01.sh
@@ -68,7 +68,8 @@ do_test()
 	for p in $pids; do
 		wait $p
 		if [ $? -ne 0 ]; then
-			tst_brk TFAIL "nfs_lock process failed"
+			tst_res TFAIL "nfs_lock process failed"
+			return
 		else
 			tst_res TINFO "$p completed"
 		fi
-- 
2.42.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [LTP] [PATCH] Fix incorrect tst_brk usage in nfslock01.sh
  2024-01-22 12:25 [LTP] [PATCH] Fix incorrect tst_brk usage in nfslock01.sh Martin Doucha
@ 2024-01-22 15:48 ` Petr Vorel
  0 siblings, 0 replies; 2+ messages in thread
From: Petr Vorel @ 2024-01-22 15:48 UTC (permalink / raw)
  To: Martin Doucha; +Cc: ltp

Hi Martin,

> In the previous release, the nfs_lock process failure would skip any
> remaining filesystems. After this change, the single filesystem test run
> will exit but all remeaining filesystems will be tested.

Thanks a lot for a fix, merged!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-01-22 15:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-22 12:25 [LTP] [PATCH] Fix incorrect tst_brk usage in nfslock01.sh Martin Doucha
2024-01-22 15:48 ` Petr Vorel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox