Re: [LTP] [PATCH V4 0/6] improvement work on libswap library

Yang Xu (Fujitsu)
2024-01-26T08:27:14Z

Hi Li,

> On Thu, Jan 25, 2024 at 3:22 AM Petr Vorel <pvorel@suse.cz> wrote:
>
>> Hi Li,
>>
>> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>>
>> Tested-by: Petr Vorel <pvorel@suse.cz>
>> On Tumbleweed 6.6 and 6.7 kernel and various SLES versions starting with
>> 4.12
>> and newer kernels.
>>
>> thanks for your work, I guess we can merge it.
>>
>
> Thanks for testing.
>
>
>>> V3-->V4
>>> * create a contiguous swapfile in swapoff01.c
>>> * fixing old-XFS requires initialize swapfile issue
>>
>>> Todo:
>>> * replace the tst_brk with tst_res+return in is_support_swap
>>> * customisze swapfile size if needed
>> OK to postpone this. I like the extended support.
>>
>> I also wonder if we should port after the release also swapon0[23].c
>> and even swapoff0[23].c to all_filesystems.
>>
>
> Yes, I can do all of that after release.
>
> @Cyril Hrubis <chrubis@suse.cz> Can I merge this patch set before release,
> it's been getting tested by Petr and me across distributions.
>
>
I would be happy to see this patchset merged, so that my v3
max_swapfiles patchset can be sent based on the latest libswap.c.

Best Regards,
Yang Xu