* [LTP] [PATCH] splice07: Whitelist /proc/self/maps on pipe write
@ 2024-01-29 10:43 Martin Doucha
2024-01-29 10:54 ` Petr Vorel
2024-01-29 15:04 ` Cyril Hrubis
0 siblings, 2 replies; 4+ messages in thread
From: Martin Doucha @ 2024-01-29 10:43 UTC (permalink / raw)
To: ltp
Just like with /dev/zero, splicing /proc/self/maps to writable pipe
is expected to pass. After generic splice() read emulation was removed,
it was reimplemented in commit b0072734ffaa ("tty, proc, kernfs, random:
Use copy_splice_read()")
Signed-off-by: Martin Doucha <mdoucha@suse.cz>
---
testcases/kernel/syscalls/splice/splice07.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/testcases/kernel/syscalls/splice/splice07.c b/testcases/kernel/syscalls/splice/splice07.c
index 1fa13b3e6..9c23e0aac 100644
--- a/testcases/kernel/syscalls/splice/splice07.c
+++ b/testcases/kernel/syscalls/splice/splice07.c
@@ -40,6 +40,7 @@ static void check_splice(struct tst_fd *fd_in, struct tst_fd *fd_out)
/* While these combinations succeeed */
case TST_FD_DEV_ZERO:
case TST_FD_FILE:
+ case TST_FD_PROC_MAPS:
case TST_FD_MEMFD:
return;
/* And this complains about socket not being connected */
--
2.42.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [LTP] [PATCH] splice07: Whitelist /proc/self/maps on pipe write
2024-01-29 10:43 [LTP] [PATCH] splice07: Whitelist /proc/self/maps on pipe write Martin Doucha
@ 2024-01-29 10:54 ` Petr Vorel
2024-01-29 15:04 ` Cyril Hrubis
1 sibling, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2024-01-29 10:54 UTC (permalink / raw)
To: Martin Doucha; +Cc: ltp
Hi Martin,
> Just like with /dev/zero, splicing /proc/self/maps to writable pipe
> is expected to pass. After generic splice() read emulation was removed,
> it was reimplemented in commit b0072734ffaa ("tty, proc, kernfs, random:
> Use copy_splice_read()")
Ah, very good catch, thank you. Kernel 6.5.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [LTP] [PATCH] splice07: Whitelist /proc/self/maps on pipe write
2024-01-29 10:43 [LTP] [PATCH] splice07: Whitelist /proc/self/maps on pipe write Martin Doucha
2024-01-29 10:54 ` Petr Vorel
@ 2024-01-29 15:04 ` Cyril Hrubis
2024-01-29 16:36 ` Petr Vorel
1 sibling, 1 reply; 4+ messages in thread
From: Cyril Hrubis @ 2024-01-29 15:04 UTC (permalink / raw)
To: Martin Doucha; +Cc: ltp
Hi!
Hopefully this is a last one...
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-01-29 16:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-29 10:43 [LTP] [PATCH] splice07: Whitelist /proc/self/maps on pipe write Martin Doucha
2024-01-29 10:54 ` Petr Vorel
2024-01-29 15:04 ` Cyril Hrubis
2024-01-29 16:36 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox