From: Petr Vorel <pvorel@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/2] Add tst_is_compat_mode() helper function
Date: Tue, 30 Jan 2024 11:30:52 +0100 [thread overview]
Message-ID: <20240130103052.GA753541@pevik> (raw)
In-Reply-To: <20240117173006.31521-1-mdoucha@suse.cz>
Hi Martin,
> New helper function to simplify checks whether the test process runs
> in e.g. 32bit compat mode on 64bit kernel.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
...
> +int tst_is_compat_mode(void)
> +{
> + return TST_ABI != tst_kernel_bits();
BTW setsockopt03.c and setsockopt08.c use:
if (tst_kernel_bits() == 32 || sizeof(long) > 4)
I guess they could also use tst_is_compat_mode().
And we have .skip_in_compat = 1, we could also add .require_compat (for
documentation purposes.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2024-01-30 10:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 17:30 [LTP] [PATCH 1/2] Add tst_is_compat_mode() helper function Martin Doucha
2024-01-17 17:30 ` [LTP] [PATCH 2/2] Add test for ASLRn't bug Martin Doucha
2024-01-30 11:29 ` Petr Vorel
2024-01-30 12:19 ` Martin Doucha
2024-01-30 12:31 ` Petr Vorel
2024-01-30 16:30 ` Petr Vorel
2024-01-30 16:32 ` Martin Doucha
2024-01-30 16:53 ` Petr Vorel
2024-01-30 10:30 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240130103052.GA753541@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox