Re: [LTP] [PATCH] waitpid01: Test all standard deadly signals

Petr Vorel
2024-02-06T11:01:06Z

> On 06. 02. 24 11:44, Petr Vorel wrote:
> > Hi Martin,

> > > On 05. 02. 24 18:34, Petr Vorel wrote:
> > > diff --git a/testcases/kernel/syscalls/waitpid/waitpid01.c
> > > b/testcases/kernel/syscalls/waitpid/waitpid01.c
> > > index 367f7875c..a42b7e8ac 100644
> > > --- a/testcases/kernel/syscalls/waitpid/waitpid01.c
> > > +++ b/testcases/kernel/syscalls/waitpid/waitpid01.c
> > > @@ -94,6 +94,9 @@ static void run(unsigned int n)
> > > int status;
> > > const struct testcase *tc = testcase_list + n;

> > > + if (tc->sig != SIGKILL)
> > > + SAFE_SIGNAL(tc->sig, SIG_DFL);
> > > +

> > Ah, reset the signal, thanks!

> > It works on the current master, but because different patch would broke your
> > waiting waitpid01 patch, so that I'll review and merge it first.

> > Will you send this as a patch or should I merge this as your Suggested-by: ?

> You can add it to the waiting waitpid01 patch and push it together as a
> single commit.

Ideally this would be a separate fix in case of revert, but yeah, I'll add it to
your next patch. Thanks!