Re: [LTP] [PATCH v2 2/2] Increase default appends operations in dio_append

[Petr Vorel <pvorel@suse.cz>]

Hi Andrea,

> From: Andrea Cervesato <andrea.cervesato@suse.com>

> This test is currently ending quite fast on regular systems, so we
> increase the number of operations in order to have bigger chances to
> find bugs.

> Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
> ---
>  testcases/kernel/io/ltp-aiodio/dio_append.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

> diff --git a/testcases/kernel/io/ltp-aiodio/dio_append.c b/testcases/kernel/io/ltp-aiodio/dio_append.c
> index 057ae73d9..0ecb76e2f 100644
> --- a/testcases/kernel/io/ltp-aiodio/dio_append.c
> +++ b/testcases/kernel/io/ltp-aiodio/dio_append.c
> @@ -33,7 +33,7 @@ static void setup(void)
>  {
>  	numchildren = 16;
>  	writesize = 64 * 1024;
> -	appends = 1000;
> +	appends = 10000;

>  	if (tst_parse_int(str_numchildren, &numchildren, 1, INT_MAX))
>  		tst_brk(TBROK, "Invalid number of children '%s'", str_numchildren);
> @@ -44,6 +44,9 @@ static void setup(void)
>  	if (tst_parse_int(str_appends, &appends, 1, INT_MAX))
>  		tst_brk(TBROK, "Invalid number of appends '%s'", str_appends);

> +	if (!tst_fs_has_free(".", appends, writesize))
> +		tst_brk(TCONF, "Not enough space to run the test");

I'm ok to keep this in single commit with increasing the number of operations,
but it should have been at least mentioned in the commit message.

And, if I understand correctly, this was meant by Cyril in v1
https://lore.kernel.org/ltp/ZbjpATp6cK9AkvBm@yuki/

Kind regards,
Petr

> +
>  	run_child = SAFE_MMAP(NULL, sizeof(int), PROT_READ | PROT_WRITE, MAP_SHARED | MAP_ANONYMOUS, -1, 0);
>  }

> @@ -97,7 +100,7 @@ static struct tst_test test = {
>  	.options = (struct tst_option[]) {
>  		{"n:", &str_numchildren, "Number of processes (default 16)"},
>  		{"w:", &str_writesize, "Write size for each append (default 64K)"},
> -		{"c:", &str_appends, "Number of appends (default 1000)"},
> +		{"c:", &str_appends, "Number of appends (default 10000)"},
>  		{}
>  	},
>  	.skip_filesystems = (const char *[]) {

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp