From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 2/2] Increase default appends operations in dio_append
Date: Wed, 31 Jan 2024 11:33:47 +0100 [thread overview]
Message-ID: <20240131103347.GA893365@pevik> (raw)
In-Reply-To: <ZbohXx6wa4ny60G1@yuki>
> Hi!
> > I'm ok to keep this in single commit with increasing the number of operations,
> > but it should have been at least mentioned in the commit message.
> The commit changelog should mention the addition of the function to
> check the available space, but otherwise it's ok.
> > And, if I understand correctly, this was meant by Cyril in v1
> > https://lore.kernel.org/ltp/ZbjpATp6cK9AkvBm@yuki/
> I mostly object to having two unrelated chnages in a single commit,
> functional fix shouldn't be cobbled togegher with a change that adjusts
> default parameters.
I figured that out, that's why I merged before you wrote. I'm sorry for the
noise.
> Also the check for a free space should be ideally added into all I/O
> tests eventually.
+1
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-01-31 10:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 10:00 [LTP] [PATCH v2 0/2] Fix dio_append test Andrea Cervesato
2024-01-31 10:00 ` [LTP] [PATCH v2 1/2] Fix dio_append/aiodio_append tests Andrea Cervesato
2024-01-31 10:21 ` Petr Vorel
2024-01-31 10:00 ` [LTP] [PATCH v2 2/2] Increase default appends operations in dio_append Andrea Cervesato
2024-01-31 10:25 ` Petr Vorel
2024-01-31 10:30 ` Petr Vorel
2024-01-31 10:30 ` Cyril Hrubis
2024-01-31 10:33 ` Petr Vorel [this message]
2024-01-31 10:24 ` [LTP] [PATCH v2 0/2] Fix dio_append test Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240131103347.GA893365@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox