public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [Patch v6 7/8] swapon/off: enable all_filesystem in swap test
Date: Wed, 31 Jan 2024 18:38:40 +0100	[thread overview]
Message-ID: <20240131173840.GA18869@pevik> (raw)
In-Reply-To: <20240131102514.2739270-8-liwang@redhat.com>

Hi Li,

LGTM

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Although get on all VMs due low memory:

tst_test.c:1091: TCONF: No enough memory for tmpfs use

instead of
libswap.c:202: TCONF: Swapfile on tmpfs not implemented

I would also suggest to print who much memory is needed, e.g.:

diff --git lib/tst_test.c lib/tst_test.c
index edb42f7f4..151c6acca 100644
--- lib/tst_test.c
+++ lib/tst_test.c
@@ -1088,7 +1088,8 @@ static const char *limit_tmpfs_mount_size(const char *mnt_data,
 		tmpfs_size = tdev.size;
 
 	if ((tst_available_mem() / 1024) < (tmpfs_size * 2))
-		tst_brk(TCONF, "No enough memory for tmpfs use");
+		tst_brk(TCONF, "No enough memory for tmpfs use (%d MB < %d MB)",
+				tst_available_mem() / 1024, tmpfs_size * 2);
 
 	if (mnt_data)
 		snprintf(buf, buf_size, "%s,size=%uM", mnt_data, tmpfs_size);

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-01-31 17:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31 10:25 [LTP] [Patch v6 0/8] improvement work on libswap library Li Wang
2024-01-31 10:25 ` [LTP] [Patch v6 1/8] libswap: add known swap supported fs check Li Wang
2024-01-31 10:25 ` [LTP] [Patch v6 2/8] swapon01: Test on all filesystems Li Wang
2024-01-31 10:25 ` [LTP] [Patch v6 3/8] swapon01: Improving test with memory limits and swap reporting Li Wang
2024-01-31 10:25 ` [LTP] [Patch v6 4/8] libswap: add function to prealloc contiguous file Li Wang
2024-01-31 10:25 ` [LTP] [Patch v6 5/8] libswap: Introduce file contiguity check Li Wang
2024-01-31 10:25 ` [LTP] [Patch v6 6/8] libswap: customize swapfile size Li Wang
2024-01-31 18:01   ` Petr Vorel
2024-01-31 10:25 ` [LTP] [Patch v6 7/8] swapon/off: enable all_filesystem in swap test Li Wang
2024-01-31 17:38   ` Petr Vorel [this message]
2024-01-31 18:53     ` Petr Vorel
2024-01-31 19:01       ` Petr Vorel
2024-02-01  6:57         ` Li Wang
2024-02-01  7:46           ` Petr Vorel
2024-02-01  8:05             ` Li Wang
2024-02-01  4:00       ` Li Wang
2024-01-31 10:25 ` [LTP] [Patch v6 8/8] libswap: Refactor is_swap_supported function to return status Li Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240131173840.GA18869@pevik \
    --to=pvorel@suse.cz \
    --cc=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox