From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77876C48285 for ; Wed, 31 Jan 2024 18:01:50 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 519A33CF91F for ; Wed, 31 Jan 2024 19:01:48 +0100 (CET) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [IPv6:2001:4b78:1:20::4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 33FD93CB75C for ; Wed, 31 Jan 2024 19:01:33 +0100 (CET) Authentication-Results: in-4.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=195.135.223.131; helo=smtp-out2.suse.de; envelope-from=pvorel@suse.cz; receiver=lists.linux.it) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 5CA7E1000BFC for ; Wed, 31 Jan 2024 19:01:32 +0100 (CET) Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6104D1FB8E; Wed, 31 Jan 2024 18:01:32 +0000 (UTC) Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 26282139D9; Wed, 31 Jan 2024 18:01:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap2.dmz-prg2.suse.org with ESMTPSA id +6HVBfyKumXfIAAAn2gu4w (envelope-from ); Wed, 31 Jan 2024 18:01:32 +0000 Date: Wed, 31 Jan 2024 19:01:30 +0100 From: Petr Vorel To: Li Wang Message-ID: <20240131180130.GB18869@pevik> References: <20240131102514.2739270-1-liwang@redhat.com> <20240131102514.2739270-7-liwang@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240131102514.2739270-7-liwang@redhat.com> Authentication-Results: smtp-out2.suse.de; none X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Rspamd-Queue-Id: 6104D1FB8E X-Virus-Scanned: clamav-milter 1.0.3 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [Patch v6 6/8] libswap: customize swapfile size X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Li, > The key change is the modification of the make_swapfile function to > accept an additional parameter blocks, specifying the number of > blocks to allocate for the swap file. This change allows for more > granular control over the size of swap files created during tests. Reviewed-by: Petr Vorel ... > diff --git a/include/libswap.h b/include/libswap.h > index d4b5301a5..e67d65756 100644 > --- a/include/libswap.h > +++ b/include/libswap.h > @@ -14,7 +14,7 @@ > /* > * Make a swap file > */ nit: it'd be nice to have a parameter description (feel free to add before merge). > -int make_swapfile(const char *swapfile, int safe); > +int make_swapfile(const char *swapfile, int blocks, int safe); Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp