public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] waitpid01: Test all standard deadly signals
Date: Tue, 6 Feb 2024 12:00:46 +0100	[thread overview]
Message-ID: <20240206110046.GB270992@pevik> (raw)
In-Reply-To: <e5ba15b7-da35-42bf-919d-160d6622b7c1@suse.cz>

> On 06. 02. 24 11:44, Petr Vorel wrote:
> > Hi Martin,

> > > On 05. 02. 24 18:34, Petr Vorel wrote:
> > > diff --git a/testcases/kernel/syscalls/waitpid/waitpid01.c
> > > b/testcases/kernel/syscalls/waitpid/waitpid01.c
> > > index 367f7875c..a42b7e8ac 100644
> > > --- a/testcases/kernel/syscalls/waitpid/waitpid01.c
> > > +++ b/testcases/kernel/syscalls/waitpid/waitpid01.c
> > > @@ -94,6 +94,9 @@ static void run(unsigned int n)
> > >          int status;
> > >          const struct testcase *tc = testcase_list + n;

> > > +       if (tc->sig != SIGKILL)
> > > +               SAFE_SIGNAL(tc->sig, SIG_DFL);
> > > +

> > Ah, reset the signal, thanks!

> > It works on the current master, but because different patch would broke your
> > waiting waitpid01 patch, so that I'll review and merge it first.

> > Will you send this as a patch or should I merge this as your Suggested-by: ?

> You can add it to the waiting waitpid01 patch and push it together as a
> single commit.

Ideally this would be a separate fix in case of revert, but yeah, I'll add it to
your next patch. Thanks!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2024-02-06 11:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-30 16:28 [LTP] [PATCH] waitpid01: Test all standard deadly signals Martin Doucha
2024-01-30 17:22 ` Petr Vorel
2024-01-31  9:05   ` Martin Doucha
2024-01-31 10:14     ` Petr Vorel
2024-01-31 10:23       ` Martin Doucha
2024-01-31 16:13         ` Petr Vorel
2024-02-05 17:34 ` Petr Vorel
2024-02-05 18:13   ` Petr Vorel
2024-02-06 10:01   ` Martin Doucha
2024-02-06 10:44     ` Petr Vorel
2024-02-06 10:49       ` Martin Doucha
2024-02-06 11:00         ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240206110046.GB270992@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=mdoucha@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox