From: Petr Vorel <pvorel@suse.cz>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 3/7] syscalls/swapon03: use tst_max_swapfiles() and GET_USED_SWAPFILES() api
Date: Sat, 10 Feb 2024 00:05:56 +0100 [thread overview]
Message-ID: <20240209230556.GA376121@pevik> (raw)
In-Reply-To: <20240208100517.1974-3-xuyang2018.jy@fujitsu.com>
Hi Yang Xu,
> + if (tst_fs_type(".") == TST_TMPFS_MAGIC)
> + tst_brk(TCONF, "swap not supported on tmpfs");
This is based on my patchset:
https://patchwork.ozlabs.org/project/ltp/patch/20240205022857.191692-2-pvorel@suse.cz/
I still wonder why this is needed. Some problem of the loop device on tmpfs or
what? Also, as it's a separate unrelated change, shouldn't we merge my commit
instead?
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-02-09 23:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 10:05 [LTP] [PATCH v3 1/7] libltpswap: Add tst_max_swapfiles api Yang Xu via ltp
2024-02-08 10:05 ` [LTP] [PATCH v3 2/7] libltpswap: alter tst_count_swaps api Yang Xu via ltp
2024-02-08 10:05 ` [LTP] [PATCH v3 3/7] syscalls/swapon03: use tst_max_swapfiles() and GET_USED_SWAPFILES() api Yang Xu via ltp
2024-02-09 23:05 ` Petr Vorel [this message]
2024-02-08 10:05 ` [LTP] [PATCH v3 4/7] swaponoff.h: Remove useless header Yang Xu via ltp
2024-02-08 10:05 ` [LTP] [PATCH v3 5/7] swapon/Makefile: Remove useless section for MAX_SWAPFILES Yang Xu via ltp
2024-02-08 10:05 ` [LTP] [PATCH v3 6/7] syscalls/swapon03: Simply this case Yang Xu via ltp
2024-02-09 22:45 ` Petr Vorel
2024-02-09 23:02 ` Petr Vorel
2024-02-08 10:05 ` [LTP] [PATCH v3 7/7] Add fallback for RHEL9 Yang Xu via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240209230556.GA376121@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox