Re: [LTP] [PATCH v4 5/7] swapon/Makefile: Remove useless section for MAX_SWAPFILES

Petr Vorel
2024-02-23T10:48:51Z

Hi Yang Xu,

> It seems this section doesn't affect anything, btw it is useless,
> so remove it.

...
> +++ b/testcases/kernel/syscalls/swapon/Makefile
> @@ -1,11 +1,6 @@
> # SPDX-License-Identifier: GPL-2.0-or-later
> # Copyright (c) International Business Machines Corp., 2001

> -NEEDSPECIAL := $(shell echo MAX_SWAPFILES | $(CC) -E -xc -include linux/swap.h 2>/dev/null - | tail -n 1 | grep 32; echo $?)
> -ifneq ($(strip $(NEEDSPECIAL)),)
> -export CFLAGS += -DOLDER_DISTRO_RELEASE

Yeah, OLDER_DISTRO_RELEASE macro is not used at all.

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr