Re: [LTP] [PATCH v5 6/7] syscalls/swapon03: Simply this case

[Petr Vorel <pvorel@suse.cz>]

Hi Yang Xu,

> Hi Petr

> > Hi Yang Xu,

> >> By moving swapfile create stage from verify_swaopon and
> >> test EPERM error more accurate. Also use glibc wrapper by
> >> using swapon/swapoff instead of call syscall number directly
> >> because glibc/musl/binoic also support them since long time ago.
> > s/binoic/bionic/

> > Reviewed-by: Petr Vorel <pvorel@suse.cz>

> Thanks for your nice review. Sorry, when your review v4 patch, I don't 
> solve all comment in v5. So I did it in my own ltp fork branch named as 
> v5_max_swapfiles[1](such as swapfiles => swap file, snprint return 
> value, else branch....).

> ps: Only the 6th patch was modified, other patches aren't modified. If 
> you see no problem, I plan to merge this patchset today.

[2] looks good to me, please merge. Very nit (feel free to ignore):
snprintf(cmd_buffer, ...) is too long, renaming cmd_buffer just to buf would
shorten whole line.

Kind regards,
Petr

> [1]https://github.com/xuyang0410/ltp/commits/v5_max_swapfiles/

[2] https://github.com/xuyang0410/ltp/commit/9e83b1fb1d8f8631122c70a336aacd28f94d8343

> Best Regards
> Yang Xu

> > Kind regards,
> > Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp