From: Li Wang <liwang@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] cgroup_dir_mk: set the umask to '0' before creating the subdir
Date: Fri, 1 Mar 2024 18:23:47 +0800 [thread overview]
Message-ID: <20240301102347.3035546-1-liwang@redhat.com> (raw)
This is to resolve the permission issue when creating
a new subdir in the cgroup, in case of system's default
umask is 0077, this will trigger issues for LTP case.
cgroup_core01.c will report following error msg:
cgroup_core01.c:50: TBROK: openat(21</sys/fs/cgroup/memory/ltp/test-3519/child_b>, 'tasks', 2, 0): EACCES (13)
Signed-off-by: Li Wang <liwang@redhat.com>
Cc: Wei Gao <wegao@suse.com>
---
Notes:
Hi Wei, can you help confirm if this patch works for you?
lib/tst_cgroup.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/tst_cgroup.c b/lib/tst_cgroup.c
index a8a598e0e..f6afb51d6 100644
--- a/lib/tst_cgroup.c
+++ b/lib/tst_cgroup.c
@@ -361,6 +361,7 @@ static void cgroup_dir_mk(const struct cgroup_dir *const parent,
struct cgroup_dir *const new)
{
const char *dpath;
+ mode_t old_umask = umask(0);
new->dir_root = parent->dir_root;
new->dir_name = dir_name;
@@ -394,6 +395,7 @@ static void cgroup_dir_mk(const struct cgroup_dir *const parent,
opendir:
new->dir_fd = SAFE_OPENAT(parent->dir_fd, dir_name,
O_PATH | O_DIRECTORY);
+ umask(old_umask);
}
#define PATH_MAX_STRLEN 4095
--
2.40.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next reply other threads:[~2024-03-01 10:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 10:23 Li Wang [this message]
2024-03-01 11:51 ` [LTP] [PATCH] cgroup_dir_mk: set the umask to '0' before creating the subdir Petr Vorel
2024-03-03 10:33 ` Wei Gao via ltp
2024-03-03 9:46 ` Wei Gao via ltp
2024-03-03 12:42 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240301102347.3035546-1-liwang@redhat.com \
--to=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox