public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v1] libswap.c: Improve caculate swap dev number
Date: Mon, 4 Mar 2024 10:04:24 +0100	[thread overview]
Message-ID: <20240304090424.GA2619408@pevik> (raw)
In-Reply-To: <CAEemH2eKts8X+tj1keU4Vqp5LwKRa8V1w7QdzGOPmC95F9JK7Q@mail.gmail.com>

> On Sun, Mar 3, 2024 at 9:14 PM Petr Vorel <pvorel@suse.cz> wrote:

> > Hi Wei, Xu,

> > > Hi  Wei

> > > > I encounter a dead loop on following code in our test on ppc64 machine:
> > > > while ((c = fgetc(fp)) != EOF)

> > > > I think "/proc/swaps" is not normal file and can not get EOF in some
> > situation,
> > > > so i use fgets a line and caculate swap dev number.

> > I guess the problem has been fixed by another patch [1], thus closing it in
> > patchwork. Please let me know if not.


> Seems not, the patch [1] below is mainly to count the free disk size.

> But Wei's work here is to calculate swap-dev numbers correctly
> (especially get rid of EOF affection to some degree).

OK, setting it as "New" again.

Kind regards,
Petr

> Xu Yang, what do you think? or did I miss anything here?

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-03-04  9:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-01  6:27 [LTP] [PATCH v1] libswap.c: Improve caculate swap dev number Wei Gao via ltp
2024-03-01  6:45 ` Yang Xu (Fujitsu) via ltp
2024-03-03 13:14   ` Petr Vorel
2024-03-04  8:49     ` Li Wang
2024-03-04  9:04       ` Petr Vorel [this message]
2024-03-04  9:18       ` Yang Xu (Fujitsu) via ltp
2024-03-04 10:04         ` Li Wang
2024-03-05  4:01           ` Wei Gao via ltp
2024-03-05 10:15             ` Petr Vorel
2024-03-05 14:10 ` [LTP] [PATCH v2] libswap.c: Improve calculate " Wei Gao via ltp
2024-03-05 14:45   ` Petr Vorel
2024-03-05 21:04   ` Petr Vorel
2024-03-06  1:32     ` Yang Xu (Fujitsu) via ltp
2024-03-06  9:59       ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240304090424.GA2619408@pevik \
    --to=pvorel@suse.cz \
    --cc=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox