From: Petr Vorel <pvorel@suse.cz>
To: Dennis Brendel <dbrendel@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3] munlockall: add test case that verifies memory has been unlocked
Date: Wed, 6 Mar 2024 13:44:36 +0100 [thread overview]
Message-ID: <20240306124436.GA746976@pevik> (raw)
In-Reply-To: <4d7c9726-d74f-41da-982c-91abca628649@redhat.com>
Hi Dennis,
> Hi Petr and Li,
> Thank you very much for your valuable feedback!
> What's left to do for me? Re-submit as v4 with sign-off and
> proper commit message?
v3 is ready to be merged, I'll add your SBT and cleanup the commit message,
while I'll be adding my and Li's RBT.
I'm just waiting a little bit because Cyril looked into this patchset,
he might have look (I merge tonight).
Kind regards,
Petr
> Thanks,
> Dennis
> On 3/6/24 11:41, Petr Vorel wrote:
> > Hi Dennis, Li,
> >> Hi Dennis,
> >> Good to see your patch soon, nice work!
> >> Next time remember to commit the patch with Signed-off-by.
> >> `git commit -sm xxxx`
> > +1 (planning to add that before merge).
> > Also these comments "Changes compared to v2:" should be below "---",
> > that way we can read them but they will not endup in the git commit message when
> > we apply the patch.
> > Kind regards,
> > Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-03-06 12:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 8:52 [LTP] [PATCH v3] munlockall: add test case that verifies memory has been unlocked Dennis Brendel
2024-03-06 10:24 ` Petr Vorel
2024-03-06 10:29 ` Li Wang
2024-03-06 10:41 ` Petr Vorel
[not found] ` <4d7c9726-d74f-41da-982c-91abca628649@redhat.com>
2024-03-06 12:44 ` Petr Vorel [this message]
2024-03-07 4:08 ` Li Wang
2024-03-06 15:26 ` Cyril Hrubis
2024-03-07 7:36 ` Dennis Brendel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240306124436.GA746976@pevik \
--to=pvorel@suse.cz \
--cc=dbrendel@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox