Re: [LTP] [PATCH v1] chdir01.c: set umask to 0 within setup

[Petr Vorel <pvorel@suse.cz>]

> Hi Martin, all,

> > Hi,
> > you're trying to fix a vfat mount quirk. We should fix that in the LTP
> > library instead, e.g. by setting umask(0) and then restoring the original
> > value inside safe_mount().

> This makes sense. FYI Wei first tried to adjust umask globally for all tests in
> the do_setup() [1], which I worried it would influence tests.

Also, it would be good to update:

https://github.com/linux-test-project/ltp/wiki/C-Test-API#21-umask

Kind regards,
Petr

> Later Li fixed problem in cgroup tests [2]. This is obviously more general
> solution, Wei please send a patch for it and to the commit message
> Suggested-by: Martin Doucha <mdoucha@suse.cz>

> While we are fixing issues caused by too restrictive umask (Wei fixed e.g.
> statx07 [3]), just to let you know that some failures are kernel failures (at
> least creat09 which uses all_filesystems, had bug on XFS [4], which got fixed
> in the kernel).

> Kind regards,
> Petr

> [1] https://lore.kernel.org/ltp/20240219134845.22171-1-wegao@suse.com/
> [2] https://github.com/linux-test-project/ltp/commit/50626b4a1d01caacd418156ec997853bd4a9fc39
> [3] https://github.com/linux-test-project/ltp/commit/d95f453ac624dc159d3acddb62eadeb9a8215f0e
> [4] https://lore.kernel.org/ltp/62343BF2.1020006@fujitsu.com/

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp