From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3] Add more testcases in mkdir03
Date: Fri, 8 Mar 2024 00:50:26 +0100 [thread overview]
Message-ID: <20240307235026.GA233637@pevik> (raw)
In-Reply-To: <Zdh8tICfdo5Y79Qp@yuki>
> Hi!
> > +#include <paths.h>
> > +#include <stdlib.h>
> > #include <errno.h>
> > #include <sys/types.h>
> > #include <sys/stat.h>
> > @@ -19,6 +21,10 @@
> > #include "tst_test.h"
> > #define TST_EEXIST "tst_eexist"
> > +#define TST_PIPE "tst_pipe"
> > +#define TST_FOLDER "tst_folder"
> > +#define TST_SYMLINK "tst_symlink"
> > +#define TST_NULLDEV _PATH_DEVNULL
> I would just hardcode the "/dev/null" here, this has potential to
> explode on alternative libc implementations, possibly Android.
> Hmm looking around the file seems to exists on Android and Musl however
> _PATH_DEVNULL is just "/dev/null" everywhere anyways.
Yeah, IMHO not that readable as hardcoded value, but it's safe to use nowadays.
Anyway, merged.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2024-03-08 1:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 15:32 [LTP] [PATCH v3] Add more testcases in mkdir03 Andrea Cervesato
2024-02-23 11:08 ` Cyril Hrubis
2024-03-07 23:50 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240307235026.GA233637@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox