From: Li Wang <liwang@redhat.com>
To: ltp@lists.linux.it, chrubis@suse.cz, pvorel@suse.cz
Subject: [LTP] [PATCH v2 3/3] stack_clash: make use of tst_kcmdline_parse
Date: Sat, 9 Mar 2024 17:01:13 +0800 [thread overview]
Message-ID: <20240309090113.3121235-4-liwang@redhat.com> (raw)
In-Reply-To: <20240309090113.3121235-1-liwang@redhat.com>
Signed-off-by: Li Wang <liwang@redhat.com>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
---
testcases/cve/stack_clash.c | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/testcases/cve/stack_clash.c b/testcases/cve/stack_clash.c
index 56b970a1b..b11774f28 100644
--- a/testcases/cve/stack_clash.c
+++ b/testcases/cve/stack_clash.c
@@ -44,6 +44,7 @@
#include <stdlib.h>
#include "tst_test.h"
+#include "tst_kconfig.h"
#include "tst_safe_stdio.h"
#include "lapi/mmap.h"
@@ -272,19 +273,14 @@ void do_child(void)
void setup(void)
{
- char buf[4096], *p;
-
page_size = sysconf(_SC_PAGESIZE);
page_mask = ~(page_size - 1);
- buf[4095] = '\0';
- SAFE_FILE_SCANF("/proc/cmdline", "%4095[^\n]", buf);
+ struct tst_kcmdline_var params = TST_KCMDLINE_INIT("stack_guard_gap");
+ tst_kcmdline_parse(¶ms, 1);
- if ((p = strstr(buf, "stack_guard_gap=")) != NULL) {
- if (sscanf(p, "stack_guard_gap=%ld", &GAP_PAGES) != 1) {
- tst_brk(TBROK | TERRNO, "sscanf");
- return;
- }
+ if (params.value[0] != '\0') {
+ GAP_PAGES= atol(params.value);
tst_res(TINFO, "stack_guard_gap = %ld", GAP_PAGES);
}
--
2.40.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2024-03-09 9:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-09 9:01 [LTP] [PATCH v2 0/3] provide a unified way to parse /proc/cmdline Li Wang
2024-03-09 9:01 ` [LTP] [PATCH v2 1/3] kconfig: add funtion " Li Wang
2024-03-11 12:27 ` Petr Vorel
2024-03-09 9:01 ` [LTP] [PATCH v2 2/3] init_module: To handle kernel module signature enforcement Li Wang
2024-03-09 9:01 ` Li Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240309090113.3121235-4-liwang@redhat.com \
--to=liwang@redhat.com \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox