From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: lkft-triage@lists.linaro.org, patches@lists.linux.dev,
Alexander Wetzel <alexander@wetzel-home.de>,
stable@vger.kernel.org, shuah@kernel.org, f.fainelli@gmail.com,
Bart Van Assche <bvanassche@acm.org>,
jonathanh@nvidia.com, patches@kernelci.org, linux@roeck-us.net,
Arnd Bergmann <arnd@arndb.de>,
srw@sladewatkins.net, broonie@kernel.org,
LTP List <ltp@lists.linux.it>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
rwarsow@gmx.de, pavel@denx.de, allen.lkml@gmail.com,
conor@kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, torvalds@linux-foundation.org,
sudipm.mukherjee@gmail.com
Subject: Re: [LTP] [PATCH 6.6 000/396] 6.6.24-rc1 review
Date: Tue, 2 Apr 2024 13:44:12 +0200 [thread overview]
Message-ID: <2024040258-disk-smokiness-5baf@gregkh> (raw)
In-Reply-To: <1d1071f3-641a-4b7c-bd35-a629ba8d5a7b@moroto.mountain>
On Tue, Apr 02, 2024 at 01:37:50PM +0300, Dan Carpenter wrote:
> On Mon, Apr 01, 2024 at 09:22:52PM +0200, Alexander Wetzel wrote:
> >
> > > Following kernel warnings have been noticed on qemu-x86_64 while running LTP
> > > cve ioctl_sg01 tests the kernel with stable-rc 6.6.24-rc1, 6.7.12-rc1 and
> > > 6.8.3-rc1.
> > >
> > > We have started bi-secting this issue.
> > > Always reproduced.
> > >
> > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > >
> > > ioctl_sg01.c:81: TINFO: Found SCSI device /dev/sg0
> > > ------------[ cut here ]------------
> > > [ 36.606841] WARNING: CPU: 0 PID: 8 at drivers/scsi/sg.c:2237
> > > sg_remove_sfp_usercontext+0x145/0x150
> > > [ 36.609445] Modules linked in:
> > > [ 36.610793] CPU: 0 PID: 8 Comm: kworker/0:0 Not tainted 6.6.24-rc1 #1
> > > [ 36.611568] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009),
> > > BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
> > > [ 36.612872] Workqueue: events sg_remove_sfp_usercontext
> > > [ 36.613691] RIP: 0010:sg_remove_sfp_usercontext+0x145/0x150
> > >
> > > <trim>
> > >
> > > [ 36.621539] Call Trace:
> > > [ 36.621953] <TASK>
> > > [ 36.622444] ? show_regs+0x69/0x80
> > > [ 36.622819] ? __warn+0x8d/0x150
> > > [ 36.623078] ? sg_remove_sfp_usercontext+0x145/0x150
> > > [ 36.623558] ? report_bug+0x171/0x1a0
> > > [ 36.623881] ? handle_bug+0x42/0x80
> > > [ 36.624070] ? exc_invalid_op+0x1c/0x70
> > > [ 36.624491] ? asm_exc_invalid_op+0x1f/0x30
> > > [ 36.624897] ? sg_remove_sfp_usercontext+0x145/0x150
> > > [ 36.625408] process_one_work+0x141/0x300
> > > [ 36.625769] worker_thread+0x2f6/0x430
> > > [ 36.626073] ? __pfx_worker_thread+0x10/0x10
> > > [ 36.626529] kthread+0x105/0x140
> > > [ 36.626778] ? __pfx_kthread+0x10/0x10
> > > [ 36.627059] ret_from_fork+0x41/0x60
> > > [ 36.627441] ? __pfx_kthread+0x10/0x10
> > > [ 36.627735] ret_from_fork_asm+0x1b/0x30
> > > [ 36.628293] </TASK>
> > > [ 36.628604] ---[ end trace 0000000000000000 ]---
> > > ioctl_sg01.c:122: TPASS: Output buffer is empty, no data leaked
> > >
> > > Suspecting commit:
> > > -----
> > > scsi: sg: Avoid sg device teardown race
> > > commit 27f58c04a8f438078583041468ec60597841284d upstream.
> > >
> >
> > Correct. The issue is already been worked on.
> >
> > commit 27f58c04a8f4 ("scsi: sg: Avoid sg device teardown race") fixed a real
> > issue. But also added an incorrect WARN_ON_ONCE(). Thus the scary - but
> > otherwise harmless - error message.
>
> If you have Reboot on Oops turned on (apparently Android enables this)
> then WARN() will reboot the system so it can be pretty annoying.
Agreed, I've dropped this stable change for now because of this.
greg k-h
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2024-04-02 12:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240401152547.867452742@linuxfoundation.org>
2024-04-01 19:01 ` [LTP] [PATCH 6.6 000/396] 6.6.24-rc1 review Naresh Kamboju
2024-04-01 19:22 ` Alexander Wetzel via ltp
2024-04-02 7:51 ` Greg Kroah-Hartman
2024-04-02 10:37 ` Dan Carpenter
2024-04-02 11:44 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024040258-disk-smokiness-5baf@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=alexander@wetzel-home.de \
--cc=allen.lkml@gmail.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=bvanassche@acm.org \
--cc=conor@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=f.fainelli@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkft-triage@lists.linaro.org \
--cc=ltp@lists.linux.it \
--cc=martin.petersen@oracle.com \
--cc=patches@kernelci.org \
--cc=patches@lists.linux.dev \
--cc=pavel@denx.de \
--cc=rwarsow@gmx.de \
--cc=shuah@kernel.org \
--cc=srw@sladewatkins.net \
--cc=stable@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox