From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC4F6CD1284 for ; Tue, 2 Apr 2024 12:00:26 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 4A2BC3CC966 for ; Tue, 2 Apr 2024 14:00:25 +0200 (CEST) Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [IPv6:2001:4b78:1:20::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 80E0F3CB2B8 for ; Tue, 2 Apr 2024 13:44:20 +0200 (CEST) Authentication-Results: in-2.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver=lists.linux.it) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id 274AA60025A for ; Tue, 2 Apr 2024 13:44:18 +0200 (CEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id DFCDF60F37; Tue, 2 Apr 2024 11:44:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0A7EC43390; Tue, 2 Apr 2024 11:44:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1712058256; bh=DpQ1x3R3SARZhczID3H+l6QkUcoWZQNWBI3Aop4zjd4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=keTjQP/TuNEFmuDJ/ndqUWVWzKYfOvgfFKfqNN1VFR3mFZpD/bcMF19oRva66l40J TP/WZx/xGTr8svgzpHSpdKh5uRIaL6B1pdxeAPF1TKw+E7yTlclI8Iukm0ycrapwyk tHj9SQQbNxN8roAmHWpZH3e6duGhE77ioZFxRHhk= Date: Tue, 2 Apr 2024 13:44:12 +0200 From: Greg Kroah-Hartman To: Dan Carpenter Message-ID: <2024040258-disk-smokiness-5baf@gregkh> References: <20240401152547.867452742@linuxfoundation.org> <29a7a1e5-da67-47fc-b1fd-ef65902ec252@wetzel-home.de> <1d1071f3-641a-4b7c-bd35-a629ba8d5a7b@moroto.mountain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1d1071f3-641a-4b7c-bd35-a629ba8d5a7b@moroto.mountain> X-Virus-Scanned: clamav-milter 1.0.3 at in-2.smtp.seeweb.it X-Virus-Status: Clean X-Mailman-Approved-At: Tue, 02 Apr 2024 13:59:52 +0200 Subject: Re: [LTP] [PATCH 6.6 000/396] 6.6.24-rc1 review X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lkft-triage@lists.linaro.org, patches@lists.linux.dev, Alexander Wetzel , stable@vger.kernel.org, shuah@kernel.org, f.fainelli@gmail.com, Bart Van Assche , jonathanh@nvidia.com, patches@kernelci.org, linux@roeck-us.net, Arnd Bergmann , srw@sladewatkins.net, broonie@kernel.org, LTP List , "Martin K. Petersen" , rwarsow@gmx.de, pavel@denx.de, allen.lkml@gmail.com, conor@kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, sudipm.mukherjee@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" On Tue, Apr 02, 2024 at 01:37:50PM +0300, Dan Carpenter wrote: > On Mon, Apr 01, 2024 at 09:22:52PM +0200, Alexander Wetzel wrote: > > > > > Following kernel warnings have been noticed on qemu-x86_64 while running LTP > > > cve ioctl_sg01 tests the kernel with stable-rc 6.6.24-rc1, 6.7.12-rc1 and > > > 6.8.3-rc1. > > > > > > We have started bi-secting this issue. > > > Always reproduced. > > > > > > Reported-by: Linux Kernel Functional Testing > > > > > > ioctl_sg01.c:81: TINFO: Found SCSI device /dev/sg0 > > > ------------[ cut here ]------------ > > > [ 36.606841] WARNING: CPU: 0 PID: 8 at drivers/scsi/sg.c:2237 > > > sg_remove_sfp_usercontext+0x145/0x150 > > > [ 36.609445] Modules linked in: > > > [ 36.610793] CPU: 0 PID: 8 Comm: kworker/0:0 Not tainted 6.6.24-rc1 #1 > > > [ 36.611568] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), > > > BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014 > > > [ 36.612872] Workqueue: events sg_remove_sfp_usercontext > > > [ 36.613691] RIP: 0010:sg_remove_sfp_usercontext+0x145/0x150 > > > > > > > > > > > > [ 36.621539] Call Trace: > > > [ 36.621953] > > > [ 36.622444] ? show_regs+0x69/0x80 > > > [ 36.622819] ? __warn+0x8d/0x150 > > > [ 36.623078] ? sg_remove_sfp_usercontext+0x145/0x150 > > > [ 36.623558] ? report_bug+0x171/0x1a0 > > > [ 36.623881] ? handle_bug+0x42/0x80 > > > [ 36.624070] ? exc_invalid_op+0x1c/0x70 > > > [ 36.624491] ? asm_exc_invalid_op+0x1f/0x30 > > > [ 36.624897] ? sg_remove_sfp_usercontext+0x145/0x150 > > > [ 36.625408] process_one_work+0x141/0x300 > > > [ 36.625769] worker_thread+0x2f6/0x430 > > > [ 36.626073] ? __pfx_worker_thread+0x10/0x10 > > > [ 36.626529] kthread+0x105/0x140 > > > [ 36.626778] ? __pfx_kthread+0x10/0x10 > > > [ 36.627059] ret_from_fork+0x41/0x60 > > > [ 36.627441] ? __pfx_kthread+0x10/0x10 > > > [ 36.627735] ret_from_fork_asm+0x1b/0x30 > > > [ 36.628293] > > > [ 36.628604] ---[ end trace 0000000000000000 ]--- > > > ioctl_sg01.c:122: TPASS: Output buffer is empty, no data leaked > > > > > > Suspecting commit: > > > ----- > > > scsi: sg: Avoid sg device teardown race > > > commit 27f58c04a8f438078583041468ec60597841284d upstream. > > > > > > > Correct. The issue is already been worked on. > > > > commit 27f58c04a8f4 ("scsi: sg: Avoid sg device teardown race") fixed a real > > issue. But also added an incorrect WARN_ON_ONCE(). Thus the scary - but > > otherwise harmless - error message. > > If you have Reboot on Oops turned on (apparently Android enables this) > then WARN() will reboot the system so it can be pretty annoying. Agreed, I've dropped this stable change for now because of this. greg k-h -- Mailing list info: https://lists.linux.it/listinfo/ltp