public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Wei Gao <wegao@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] zram01.sh: Increase timeout for check_read_mem_used_total
Date: Thu, 18 Apr 2024 16:22:02 +0200	[thread overview]
Message-ID: <20240418142202.GA100561@pevik> (raw)
In-Reply-To: <20240411044645.29938-1-wegao@suse.com>

Hi all,

> Increase timeout value to let case pass on our low ppc64le
nit: s/low/low resource/
> machine.

> Signed-off-by: Wei Gao <wegao@suse.com>
> ---
>  testcases/kernel/device-drivers/zram/zram01.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/testcases/kernel/device-drivers/zram/zram01.sh b/testcases/kernel/device-drivers/zram/zram01.sh
> index 0c100b706..959dab217 100755
> --- a/testcases/kernel/device-drivers/zram/zram01.sh
> +++ b/testcases/kernel/device-drivers/zram/zram01.sh
> @@ -155,7 +155,7 @@ zram_fill_fs()
>  			continue
>  		fi

> -		TST_RETRY_FUNC "check_read_mem_used_total /sys/block/zram$i/mm_stat" 0
> +		TST_RETRY_FN_EXP_BACKOFF "check_read_mem_used_total /sys/block/zram$i/mm_stat" 0 10

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Sounds ok for me to avoid timeout.
@Cyril, @Li WDYT? Or do you smell bug we try to cover?

Kind regards,
Petr

>  		mem_used_total=$(read_mem_used_total /sys/block/zram$i/mm_stat)
>  		tst_res TINFO "mem_used_total: $mem_used_total"

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-04-18 14:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-11  4:46 [LTP] [PATCH v1] zram01.sh: Increase timeout for check_read_mem_used_total Wei Gao via ltp
2024-04-18 14:22 ` Petr Vorel [this message]
2024-05-07  6:41   ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240418142202.GA100561@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=wegao@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox