From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 1/2] libswap: Add {SAFE_, }MAKE_MINIMAL_SWAPFILE() macros
Date: Fri, 19 Apr 2024 08:12:06 +0200 [thread overview]
Message-ID: <20240419061206.GA143961@pevik> (raw)
In-Reply-To: <CAEemH2fr5+L0UK4McWf7Aos9TciME7wHMQmVujNX8xQtZYUsqQ@mail.gmail.com>
> On Fri, Apr 19, 2024 at 9:50 AM Li Wang <liwang@redhat.com> wrote:
> > Hi Petr, Cyril,
> > The patchset generally looks good.
> > But I have a concern about the macro name "MINIMAL" word,
> > which misled people to think that is the minimal swapfile size we
> > can make on the system, but obviously it is not, we could even
> > create a smaller one, right?
> > Can we rename it with a better one?
> What about MAKE_DEFAULT_SWAPFILE, or MAKE_TEST_SWAPFILE?
I want to somehow express that it's a really small swap file
(although sure, not minimal). Sure, it can be "default" or "test",
but it does not say anything about the size.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-04-19 6:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 18:52 [LTP] [PATCH v2 0/2] swap{on,off} fixes for page size > 4KB Petr Vorel
2024-04-18 18:52 ` [LTP] [PATCH v2 1/2] libswap: Add {SAFE_, }MAKE_MINIMAL_SWAPFILE() macros Petr Vorel
2024-04-19 1:50 ` Li Wang
2024-04-19 2:04 ` Li Wang
2024-04-19 6:12 ` Petr Vorel [this message]
2024-04-19 8:47 ` Li Wang
2024-04-19 9:40 ` Petr Vorel
2024-04-19 8:50 ` Cyril Hrubis
2024-04-18 18:52 ` [LTP] [PATCH v2 2/2] libswap: Use {SAFE_,}MAKE_MINIMAL_SWAPFILE() Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240419061206.GA143961@pevik \
--to=pvorel@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox