From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 1/2] libswap: Add {SAFE_, }MAKE_SMALL_SWAPFILE() macros
Date: Fri, 26 Apr 2024 06:23:57 +0200 [thread overview]
Message-ID: <20240426042357.GA325890@pevik> (raw)
In-Reply-To: <CAEemH2ekBY=-DR0ksjB2SjK6di_9hDpnrE58AA+vwxix0R8chw@mail.gmail.com>
Hi Li, all,
...
> Reviewed-by: Li Wang <liwang@redhat.com>
Merged, thank you for your review!
> ---
> > include/libswap.h | 18 ++++++++++++++++++
...
> > +/** 65536 bytes is minimum for 64kb page size, let's use 1 MB */
> > +#define MINIMAL_SWAP_SIZE_MB 1
> > +
> > +/**
> > + * Macro to create minimal swapfile.
This could have been done better, e.g.:
@swapfile: swap file name.
But I kept it the same, just to fix broken test. Ands I'm going to send patch
implement it.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-04-26 4:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 21:10 [LTP] [PATCH v3 0/2] swap{on,off} fixes for page size > 4KB Petr Vorel
2024-04-25 21:10 ` [LTP] [PATCH v3 1/2] libswap: Add {SAFE_, }MAKE_SMALL_SWAPFILE() macros Petr Vorel
2024-04-26 2:31 ` Li Wang
2024-04-26 4:23 ` Petr Vorel [this message]
2024-04-25 21:10 ` [LTP] [PATCH v3 2/2] libswap: Use {SAFE_,}MAKE_MINIMAL_SWAPFILE() Petr Vorel
2024-04-26 2:32 ` [LTP] [PATCH v3 2/2] libswap: Use {SAFE_, }MAKE_MINIMAL_SWAPFILE() Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240426042357.GA325890@pevik \
--to=pvorel@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox