public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] doc: libltpswap: Add kerneldoc
Date: Fri, 26 Apr 2024 20:28:53 +0200	[thread overview]
Message-ID: <20240426182853.GE6871@pevik> (raw)
In-Reply-To: <3b2f3b29-153f-4921-bd51-cc32d2749881@suse.com>

Hi Andrea,

> > - * Macro to create minimal swapfile.
> > + * MAKE_SMALL_SWAPFILE - create small swap file.
> > + *
> > + * Macro to create small small swap file. Size defined with MINIMAL_SWAP_SIZE_MB.
> "small small" sounds weird. Maybe "really small"

+1, my typo, thanks!

> > + *
> > + * @swapfile: swap filename.
> >    */
> >   #define MAKE_SMALL_SWAPFILE(swapfile) \
> >       make_swapfile(__FILE__, __LINE__, swapfile, MINIMAL_SWAP_SIZE_MB, 0, \
> >   		  SWAPFILE_BY_SIZE)
> >   /**
> > - * Macro to create minimal swapfile.
> > + * SAFE_MAKE_SMALL_SWAPFILE - create small swap file (safe version).
> > + *
> > + * Macro to create small small swap file. Size defined with MINIMAL_SWAP_SIZE_MB.
> >    * Includes safety checks to handle potential errors.
> Same here
Yeah.

BTW we need to have CI job which tries to generate our docs with sphinx.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      parent reply	other threads:[~2024-04-26 18:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-26  4:28 [LTP] [PATCH 1/1] doc: libltpswap: Add kerneldoc Petr Vorel
2024-04-26  7:43 ` Andrea Cervesato via ltp
2024-04-26  8:30   ` Li Wang
2024-04-26 18:25     ` Petr Vorel
2024-05-07  8:28       ` Andrea Cervesato via ltp
2024-05-07  8:31         ` Petr Vorel
2024-04-26 18:28   ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240426182853.GE6871@pevik \
    --to=pvorel@suse.cz \
    --cc=andrea.cervesato@suse.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox