* [LTP] [PATCH v1] zram01.sh: Increase timeout for check_read_mem_used_total
@ 2024-04-11 4:46 Wei Gao via ltp
2024-04-18 14:22 ` Petr Vorel
0 siblings, 1 reply; 3+ messages in thread
From: Wei Gao via ltp @ 2024-04-11 4:46 UTC (permalink / raw)
To: ltp
Increase timeout value to let case pass on our low ppc64le
machine.
Signed-off-by: Wei Gao <wegao@suse.com>
---
testcases/kernel/device-drivers/zram/zram01.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testcases/kernel/device-drivers/zram/zram01.sh b/testcases/kernel/device-drivers/zram/zram01.sh
index 0c100b706..959dab217 100755
--- a/testcases/kernel/device-drivers/zram/zram01.sh
+++ b/testcases/kernel/device-drivers/zram/zram01.sh
@@ -155,7 +155,7 @@ zram_fill_fs()
continue
fi
- TST_RETRY_FUNC "check_read_mem_used_total /sys/block/zram$i/mm_stat" 0
+ TST_RETRY_FN_EXP_BACKOFF "check_read_mem_used_total /sys/block/zram$i/mm_stat" 0 10
mem_used_total=$(read_mem_used_total /sys/block/zram$i/mm_stat)
tst_res TINFO "mem_used_total: $mem_used_total"
--
2.35.3
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH v1] zram01.sh: Increase timeout for check_read_mem_used_total
2024-04-11 4:46 [LTP] [PATCH v1] zram01.sh: Increase timeout for check_read_mem_used_total Wei Gao via ltp
@ 2024-04-18 14:22 ` Petr Vorel
2024-05-07 6:41 ` Petr Vorel
0 siblings, 1 reply; 3+ messages in thread
From: Petr Vorel @ 2024-04-18 14:22 UTC (permalink / raw)
To: Wei Gao; +Cc: ltp
Hi all,
> Increase timeout value to let case pass on our low ppc64le
nit: s/low/low resource/
> machine.
> Signed-off-by: Wei Gao <wegao@suse.com>
> ---
> testcases/kernel/device-drivers/zram/zram01.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/testcases/kernel/device-drivers/zram/zram01.sh b/testcases/kernel/device-drivers/zram/zram01.sh
> index 0c100b706..959dab217 100755
> --- a/testcases/kernel/device-drivers/zram/zram01.sh
> +++ b/testcases/kernel/device-drivers/zram/zram01.sh
> @@ -155,7 +155,7 @@ zram_fill_fs()
> continue
> fi
> - TST_RETRY_FUNC "check_read_mem_used_total /sys/block/zram$i/mm_stat" 0
> + TST_RETRY_FN_EXP_BACKOFF "check_read_mem_used_total /sys/block/zram$i/mm_stat" 0 10
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Sounds ok for me to avoid timeout.
@Cyril, @Li WDYT? Or do you smell bug we try to cover?
Kind regards,
Petr
> mem_used_total=$(read_mem_used_total /sys/block/zram$i/mm_stat)
> tst_res TINFO "mem_used_total: $mem_used_total"
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH v1] zram01.sh: Increase timeout for check_read_mem_used_total
2024-04-18 14:22 ` Petr Vorel
@ 2024-05-07 6:41 ` Petr Vorel
0 siblings, 0 replies; 3+ messages in thread
From: Petr Vorel @ 2024-05-07 6:41 UTC (permalink / raw)
To: Wei Gao, ltp
Hi all,
> Hi all,
> > Signed-off-by: Wei Gao <wegao@suse.com>
...
> > diff --git a/testcases/kernel/device-drivers/zram/zram01.sh b/testcases/kernel/device-drivers/zram/zram01.sh
> > index 0c100b706..959dab217 100755
> > --- a/testcases/kernel/device-drivers/zram/zram01.sh
> > +++ b/testcases/kernel/device-drivers/zram/zram01.sh
> > @@ -155,7 +155,7 @@ zram_fill_fs()
> > continue
> > fi
> > - TST_RETRY_FUNC "check_read_mem_used_total /sys/block/zram$i/mm_stat" 0
> > + TST_RETRY_FN_EXP_BACKOFF "check_read_mem_used_total /sys/block/zram$i/mm_stat" 0 10
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> Sounds ok for me to avoid timeout.
> @Cyril, @Li WDYT? Or do you smell bug we try to cover?
FYI merged. Thanks!
Kind regards,
Petr
> Kind regards,
> Petr
> > mem_used_total=$(read_mem_used_total /sys/block/zram$i/mm_stat)
> > tst_res TINFO "mem_used_total: $mem_used_total"
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-07 6:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-11 4:46 [LTP] [PATCH v1] zram01.sh: Increase timeout for check_read_mem_used_total Wei Gao via ltp
2024-04-18 14:22 ` Petr Vorel
2024-05-07 6:41 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox