* [LTP] [PATCH 1/1] mmap15: Enable in compat mode
@ 2024-05-06 20:43 Petr Vorel
2024-05-07 1:29 ` Li Wang
0 siblings, 1 reply; 3+ messages in thread
From: Petr Vorel @ 2024-05-06 20:43 UTC (permalink / raw)
To: ltp
Test actually runs well in compat mode. Skipping in 32 bit was
originally added bc8d45a43 (in 2004, in hugemmap03.c), likely kernel or
libc functionality changed.
Tested on recent 6.7 kernel and very old 4.4 kernel.
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
testcases/kernel/syscalls/mmap/mmap15.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/testcases/kernel/syscalls/mmap/mmap15.c b/testcases/kernel/syscalls/mmap/mmap15.c
index 71c18a10a..2128e0b57 100644
--- a/testcases/kernel/syscalls/mmap/mmap15.c
+++ b/testcases/kernel/syscalls/mmap/mmap15.c
@@ -61,6 +61,5 @@ static struct tst_test test = {
.setup = setup,
.cleanup = cleanup,
.test_all = run,
- .skip_in_compat = 1,
.needs_tmpdir = 1
};
--
2.43.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH 1/1] mmap15: Enable in compat mode
2024-05-06 20:43 [LTP] [PATCH 1/1] mmap15: Enable in compat mode Petr Vorel
@ 2024-05-07 1:29 ` Li Wang
2024-05-07 7:48 ` Petr Vorel
0 siblings, 1 reply; 3+ messages in thread
From: Li Wang @ 2024-05-07 1:29 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
On Tue, May 7, 2024 at 4:43 AM Petr Vorel <pvorel@suse.cz> wrote:
> Test actually runs well in compat mode. Skipping in 32 bit was
> originally added bc8d45a43 (in 2004, in hugemmap03.c), likely kernel or
> libc functionality changed.
>
> Tested on recent 6.7 kernel and very old 4.4 kernel.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
>
Reviewed-by: Li Wang <liwang@redhat.com>
> ---
> testcases/kernel/syscalls/mmap/mmap15.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/testcases/kernel/syscalls/mmap/mmap15.c
> b/testcases/kernel/syscalls/mmap/mmap15.c
> index 71c18a10a..2128e0b57 100644
> --- a/testcases/kernel/syscalls/mmap/mmap15.c
> +++ b/testcases/kernel/syscalls/mmap/mmap15.c
> @@ -61,6 +61,5 @@ static struct tst_test test = {
> .setup = setup,
> .cleanup = cleanup,
> .test_all = run,
> - .skip_in_compat = 1,
> .needs_tmpdir = 1
> };
> --
> 2.43.0
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
>
>
--
Regards,
Li Wang
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH 1/1] mmap15: Enable in compat mode
2024-05-07 1:29 ` Li Wang
@ 2024-05-07 7:48 ` Petr Vorel
0 siblings, 0 replies; 3+ messages in thread
From: Petr Vorel @ 2024-05-07 7:48 UTC (permalink / raw)
To: Li Wang; +Cc: ltp
Hi Li,
thanks for your review, merged!
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-07 7:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-06 20:43 [LTP] [PATCH 1/1] mmap15: Enable in compat mode Petr Vorel
2024-05-07 1:29 ` Li Wang
2024-05-07 7:48 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox