From: Petr Vorel <pvorel@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/9] KVM: Disable EBP register use in 32bit code
Date: Tue, 7 May 2024 16:22:04 +0200 [thread overview]
Message-ID: <20240507142204.GA138935@pevik> (raw)
In-Reply-To: <cd8f5fb9-606b-4543-8a3e-02079d2ea630@suse.cz>
> On 06. 05. 24 21:41, Petr Vorel wrote:
> > > ifeq ($(HOST_CPU),x86)
> > > - GUEST_CFLAGS += -m32
> > > + GUEST_CFLAGS += -m32 -ffixed-ebp
> > FYI this will fail on 32 bit build on clang:
> > clang: error: unknown argument: '-ffixed-ebp'
> > I don't want to block this patchset which brings important test, but it'd be
> > great to fix it.
> > Is there clang equivalent? Or is it even needed for clang?
> > Either way, we need to detect clang. I don't think simple
> > ifeq ($(CXX),clang)
> > would be enough, because cc can be alias to clang.
> Hmm, I need to fix this. I guess that configure should just check for
> -ffixed-ebp support.
Yes, that would be ideal solution which I definitely don't want to force you.
> Fortunately, clang doesn't generate code that would
> trigger stack segment fault so the workaround is only needed for GCC.
Great!
> Could you review and merge the trivial patches (4, 5, 6, 7) so that I don't
> need to resubmit everything?
Sure!
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-05-07 14:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 12:21 [LTP] [PATCH 0/9] Add functional test for AMD VMSAVE/VMLOAD instructions Martin Doucha
2024-04-30 12:21 ` [LTP] [PATCH 1/9] KVM: Disable EBP register use in 32bit code Martin Doucha
2024-05-06 19:41 ` Petr Vorel
2024-05-07 14:10 ` Martin Doucha
2024-05-07 14:22 ` Petr Vorel [this message]
2024-05-07 14:25 ` Petr Vorel
2024-05-07 14:45 ` Martin Doucha
2024-04-30 12:21 ` [LTP] [PATCH 2/9] KVM: Implement strchr() and basic sprintf() Martin Doucha
2024-04-30 12:21 ` [LTP] [PATCH 3/9] KVM: Implement printf-like formatting for tst_res() and tst_brk() Martin Doucha
2024-04-30 12:22 ` [LTP] [PATCH 4/9] kvm_svm02: Fix saved stack segment index value Martin Doucha
2024-04-30 12:22 ` [LTP] [PATCH 5/9] kvm_find_free_descriptor(): Skip descriptor 0 Martin Doucha
2024-04-30 12:22 ` [LTP] [PATCH 6/9] KVM: Add system control MSR constants Martin Doucha
2024-04-30 12:22 ` [LTP] [PATCH 7/9] KVM: Add VMSAVE/VMLOAD functions to x86 SVM library Martin Doucha
2024-05-07 14:57 ` Petr Vorel
2024-04-30 12:22 ` [LTP] [PATCH 8/9] KVM: Add functional test for VMSAVE/VMLOAD instructions Martin Doucha
2024-04-30 12:22 ` [LTP] [PATCH 9/9] KVM: Move kvm_pagefault01 to the end of KVM runfile Martin Doucha
2024-05-06 4:34 ` Petr Vorel
2024-05-07 14:59 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240507142204.GA138935@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox