[LTP] [PATCH 0/3] runtest cleanup

[LTP] [PATCH 0/3] runtest cleanup

[Petr Vorel]

Petr Vorel (3):
  runtest: Move capability related tests to new capability
  runtest: Move io content to ltp-aiodio.part4
  runtest: Remove 'ltp-' prefix from aio* runtests

 runtest/{ltp-aio-stress => aio-stress}     | 0
 runtest/{ltp-aiodio.part1 => aiodio.part1} | 0
 runtest/{ltp-aiodio.part2 => aiodio.part2} | 0
 runtest/{ltp-aiodio.part3 => aiodio.part3} | 0
 runtest/{ltp-aiodio.part4 => aiodio.part4} | 6 +++---
 runtest/cap_bounds                         | 2 --
 runtest/{securebits => capability}         | 5 ++++-
 runtest/filecaps                           | 2 --
 runtest/io                                 | 3 ---
 9 files changed, 7 insertions(+), 11 deletions(-)
 rename runtest/{ltp-aio-stress => aio-stress} (100%)
 rename runtest/{ltp-aiodio.part1 => aiodio.part1} (100%)
 rename runtest/{ltp-aiodio.part2 => aiodio.part2} (100%)
 rename runtest/{ltp-aiodio.part3 => aiodio.part3} (100%)
 rename runtest/{ltp-aiodio.part4 => aiodio.part4} (90%)
 delete mode 100644 runtest/cap_bounds
 rename runtest/{securebits => capability} (53%)
 delete mode 100644 runtest/filecaps
 delete mode 100644 runtest/io

-- 
2.43.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH 1/3] runtest: Move capability related tests to new capability

[Petr Vorel]

Move cap_bounds content to syscalls

runtest/cap_bounds and runtest/filecaps had both only single entry.
That's a waste of starting SUT, therefore create new runtest file
capability and move it there. Add there also runtest/securebits.

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Maybe it'd be safer to verify if the tests are still relevant now.
Because name is more promising than the actual content :).
Also we have other tests which use libcap.
Alternatively, we could just move them to syscalls.

 runtest/cap_bounds                 | 2 --
 runtest/{securebits => capability} | 5 ++++-
 runtest/filecaps                   | 2 --
 3 files changed, 4 insertions(+), 5 deletions(-)
 delete mode 100644 runtest/cap_bounds
 rename runtest/{securebits => capability} (53%)
 delete mode 100644 runtest/filecaps

diff --git a/runtest/cap_bounds b/runtest/cap_bounds
deleted file mode 100644
index 518d1e3ab..000000000
--- a/runtest/cap_bounds
+++ /dev/null
@@ -1,2 +0,0 @@
-#DESCRIPTION:Posix capability bounding set
-Cap_bounds	run_capbounds.sh
diff --git a/runtest/securebits b/runtest/capability
similarity index 53%
rename from runtest/securebits
rename to runtest/capability
index 64e6e0a0d..c7af1235e 100644
--- a/runtest/securebits
+++ b/runtest/capability
@@ -1,4 +1,7 @@
-#DESCRIPTION:securebits tests
+# various capability related tests
+cap_bounds run_capbounds.sh
+filecaps filecapstest.sh
+
 check_keepcaps01 check_keepcaps 1
 check_keepcaps02 check_keepcaps 2
 check_keepcaps03 check_keepcaps 3
diff --git a/runtest/filecaps b/runtest/filecaps
deleted file mode 100644
index 1872c0bc5..000000000
--- a/runtest/filecaps
+++ /dev/null
@@ -1,2 +0,0 @@
-#DESCRIPTION:file capabilities
-Filecaps	filecapstest.sh
-- 
2.43.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/3] runtest: Move capability related tests to new capability

[Cyril Hrubis]

Hi!
> Move cap_bounds content to syscalls
> 
> runtest/cap_bounds and runtest/filecaps had both only single entry.
> That's a waste of starting SUT, therefore create new runtest file
> capability and move it there. Add there also runtest/securebits.
> 
> Signed-off-by: Petr Vorel <pvorel@suse.cz>

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

> ---
> Maybe it'd be safer to verify if the tests are still relevant now.
> Because name is more promising than the actual content :).
> Also we have other tests which use libcap.
> Alternatively, we could just move them to syscalls.

I would just merge them for now, since it's better than having one or
two tests per file.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/3] runtest: Move capability related tests to new capability

[Petr Vorel]

Hi Cyril,

> Hi!
> > Move cap_bounds content to syscalls

> > runtest/cap_bounds and runtest/filecaps had both only single entry.
> > That's a waste of starting SUT, therefore create new runtest file
> > capability and move it there. Add there also runtest/securebits.

> > Signed-off-by: Petr Vorel <pvorel@suse.cz>

> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

> > ---
> > Maybe it'd be safer to verify if the tests are still relevant now.
> > Because name is more promising than the actual content :).
> > Also we have other tests which use libcap.
> > Alternatively, we could just move them to syscalls.

> I would just merge them for now, since it's better than having one or
> two tests per file.

Right, merged this and 2nd patch. Thanks for your review!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH 2/3] runtest: Move io content to ltp-aiodio.part4

[Petr Vorel]

+ Remove bogus comments.

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 runtest/io               | 3 ---
 runtest/ltp-aiodio.part4 | 6 +++---
 2 files changed, 3 insertions(+), 6 deletions(-)
 delete mode 100644 runtest/io

diff --git a/runtest/io b/runtest/io
deleted file mode 100644
index cd51cce3c..000000000
--- a/runtest/io
+++ /dev/null
@@ -1,3 +0,0 @@
-#AIO01 & AIO02 tests to be run
-aio01 aio01
-aio02 aio02
diff --git a/runtest/ltp-aiodio.part4 b/runtest/ltp-aiodio.part4
index c31bef934..de00b8a78 100644
--- a/runtest/ltp-aiodio.part4
+++ b/runtest/ltp-aiodio.part4
@@ -1,6 +1,6 @@
-# 3/2006
-# Malcles Jacky: this file is a copy from Ridgeway Marty's aio script
-#     goal: all aio tests using the same framework
+aio01 aio01
+aio02 aio02
+
 #Running dio_sparse & dirty tests
 DI000 dirty
 DS000 dio_sparse
-- 
2.43.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 2/3] runtest: Move io content to ltp-aiodio.part4

[Cyril Hrubis]

Hi!
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH 3/3] runtest: Remove 'ltp-' prefix from aio* runtests

[Petr Vorel]

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Renaming runtest files will force people to rename in their frameworks /
toolings, but it's nice to be consistent.

 runtest/{ltp-aio-stress => aio-stress}     | 0
 runtest/{ltp-aiodio.part1 => aiodio.part1} | 0
 runtest/{ltp-aiodio.part2 => aiodio.part2} | 0
 runtest/{ltp-aiodio.part3 => aiodio.part3} | 0
 runtest/{ltp-aiodio.part4 => aiodio.part4} | 0
 5 files changed, 0 insertions(+), 0 deletions(-)
 rename runtest/{ltp-aio-stress => aio-stress} (100%)
 rename runtest/{ltp-aiodio.part1 => aiodio.part1} (100%)
 rename runtest/{ltp-aiodio.part2 => aiodio.part2} (100%)
 rename runtest/{ltp-aiodio.part3 => aiodio.part3} (100%)
 rename runtest/{ltp-aiodio.part4 => aiodio.part4} (100%)

diff --git a/runtest/ltp-aio-stress b/runtest/aio-stress
similarity index 100%
rename from runtest/ltp-aio-stress
rename to runtest/aio-stress
diff --git a/runtest/ltp-aiodio.part1 b/runtest/aiodio.part1
similarity index 100%
rename from runtest/ltp-aiodio.part1
rename to runtest/aiodio.part1
diff --git a/runtest/ltp-aiodio.part2 b/runtest/aiodio.part2
similarity index 100%
rename from runtest/ltp-aiodio.part2
rename to runtest/aiodio.part2
diff --git a/runtest/ltp-aiodio.part3 b/runtest/aiodio.part3
similarity index 100%
rename from runtest/ltp-aiodio.part3
rename to runtest/aiodio.part3
diff --git a/runtest/ltp-aiodio.part4 b/runtest/aiodio.part4
similarity index 100%
rename from runtest/ltp-aiodio.part4
rename to runtest/aiodio.part4
-- 
2.43.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 3/3] runtest: Remove 'ltp-' prefix from aio* runtests

[Cyril Hrubis]

Hi!
> Renaming runtest files will force people to rename in their frameworks /
> toolings, but it's nice to be consistent.

I do not think that this is worth of the trouble.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 3/3] runtest: Remove 'ltp-' prefix from aio* runtests

[Petr Vorel]

Hi Cyril,

> Hi!
> > Renaming runtest files will force people to rename in their frameworks /
> > toolings, but it's nice to be consistent.

> I do not think that this is worth of the trouble.

Sure, setting patch as rejected.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp