* [LTP] [PATCH 1/1] wait01: Use TST_EXP_FAIL2() for wait
@ 2024-05-09 14:40 Petr Vorel
2024-05-09 14:58 ` Cyril Hrubis
0 siblings, 1 reply; 3+ messages in thread
From: Petr Vorel @ 2024-05-09 14:40 UTC (permalink / raw)
To: ltp
Both wait() and waitpid() return PID, therefore (similarly as for file
descriptor) pass condition is >= 0, which is in TST_EXP_FAIL2().
Therefore TST_EXP_FAIL2() or TST_EXP_PID{,_SILENT} needs to be used.
Affected only wait01.
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
testcases/kernel/syscalls/wait/wait01.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testcases/kernel/syscalls/wait/wait01.c b/testcases/kernel/syscalls/wait/wait01.c
index aec91b911..8245898dd 100644
--- a/testcases/kernel/syscalls/wait/wait01.c
+++ b/testcases/kernel/syscalls/wait/wait01.c
@@ -16,7 +16,7 @@
static void verify_wait(void)
{
- TST_EXP_FAIL(wait(NULL), ECHILD);
+ TST_EXP_FAIL2(wait(NULL), ECHILD);
}
static struct tst_test test = {
--
2.43.0
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH 1/1] wait01: Use TST_EXP_FAIL2() for wait
2024-05-09 14:40 [LTP] [PATCH 1/1] wait01: Use TST_EXP_FAIL2() for wait Petr Vorel
@ 2024-05-09 14:58 ` Cyril Hrubis
2024-05-09 15:27 ` Petr Vorel
0 siblings, 1 reply; 3+ messages in thread
From: Cyril Hrubis @ 2024-05-09 14:58 UTC (permalink / raw)
To: Petr Vorel; +Cc: ltp
Hi!
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH 1/1] wait01: Use TST_EXP_FAIL2() for wait
2024-05-09 14:58 ` Cyril Hrubis
@ 2024-05-09 15:27 ` Petr Vorel
0 siblings, 0 replies; 3+ messages in thread
From: Petr Vorel @ 2024-05-09 15:27 UTC (permalink / raw)
To: Cyril Hrubis; +Cc: ltp
Hi Cyril,
> Hi!
> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
Merged, thanks!
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-09 15:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-09 14:40 [LTP] [PATCH 1/1] wait01: Use TST_EXP_FAIL2() for wait Petr Vorel
2024-05-09 14:58 ` Cyril Hrubis
2024-05-09 15:27 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox