From: Petr Vorel <pvorel@suse.cz>
To: Joerg.Vehlow@aox.de
Cc: Detlef Riekenberg <wine.dev@web.de>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] open_posix_testsuite: Remove inclomplete warning commandline argument
Date: Mon, 13 May 2024 12:47:31 +0200 [thread overview]
Message-ID: <20240513104731.GA63875@pevik> (raw)
In-Reply-To: <a182355e-d425-4646-90da-a6c86d11262c@jv-coder.de>
Hi all,
> Hi,
> Am 5/9/2024 um 11:21 AM schrieb Cyril Hrubis:
> > Hi!
> >> The Open Posix testsuite calls the compiler with the commandline argument
> >> "-W", but that is not a supported gcc warning option
> >> and breaks other compiler.
> >> This patch removes the broken "-W" commandline argument.
> > Isn't -W old name for -Wextra?
> exactly that is what gcc and clang documentation states.
> On top of that
> Additionally it is nothing introduced by 8071ba7, but already by
> ff4e69314c1 back in 2013 by no one else but you Cyril ;)
Yes, it should be:
Fixes: ff4e69314 ("open_posix_testsuite: Enable warnings.")
> I guess changing it to -Wextra wouldn't hurt and is what gcc recommends.
+1 for replacing -W with -Wextra
FYI if we are interested what is behind -Wextra
https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-W
https://github.com/llvm-mirror/clang/blob/master/include/clang/Basic/DiagnosticGroups.td
Kind regards,
Petr
> Jörg
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-05-13 10:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 21:01 [LTP] [PATCH] open_posix_testsuite: Remove inclomplete warning commandline argument Detlef Riekenberg via ltp
2024-05-09 9:21 ` Cyril Hrubis
2024-05-13 4:34 ` Joerg Vehlow
2024-05-13 10:47 ` Petr Vorel [this message]
2024-05-13 12:26 ` Cyril Hrubis
2024-05-13 13:09 ` Petr Vorel
-- strict thread matches above, loose matches on Subject: below --
2024-05-08 20:51 Detlef Riekenberg via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240513104731.GA63875@pevik \
--to=pvorel@suse.cz \
--cc=Joerg.Vehlow@aox.de \
--cc=ltp@lists.linux.it \
--cc=wine.dev@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox