[LTP] [PATCH] open_posix_testsuite: Replace old -W commandline argument

[LTP] [PATCH] open_posix_testsuite: Replace old -W commandline argument

[Detlef Riekenberg via ltp]

The Open Posix testsuite calls the compiler with the old
gcc commandline argument "-W", but that breaks other compiler

This patch renames the old "-W" to "-Wextra" (as suggested by LTP mailing list members)

Reference:
https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html

gcc 3.4 renamed "-W" to "-Wextra" in 2004:
https://gcc.gnu.org/gcc-3.4/changes.html

--
Regards ... Detlef

Signed-off-by: Detlef Riekenberg <wine.dev@web.de>
---
 testcases/open_posix_testsuite/include/mk/config.mk.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testcases/open_posix_testsuite/include/mk/config.mk.in b/testcases/open_posix_testsuite/include/mk/config.mk.in
index c9a4b5c5a..20422e0f1 100644
--- a/testcases/open_posix_testsuite/include/mk/config.mk.in
+++ b/testcases/open_posix_testsuite/include/mk/config.mk.in
@@ -14,4 +14,4 @@ testdir_rel := @testdir@
 testdir     := ${prefix}/${testdir_rel}
 testdir_bin := ${testdir}/bin

-CFLAGS  += -std=c99 -D_POSIX_C_SOURCE=200809L -D_XOPEN_SOURCE=700 -W -Wall
+CFLAGS  += -std=c99 -D_POSIX_C_SOURCE=200809L -D_XOPEN_SOURCE=700 -Wall -Wextra
--
2.40.1



-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] open_posix_testsuite: Replace old -W commandline argument

[Cyril Hrubis]

Hi!
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] open_posix_testsuite: Replace old -W commandline argument

[Petr Vorel]

Hi all,

Reviewed-by: Petr Vorel <pvorel@suse.cz>

@Joerg I plan to merge this, can I add your Reviewed-by tag?

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] open_posix_testsuite: Replace old -W commandline argument

[Joerg Vehlow]

Hi,

Am 5/14/2024 um 2:15 PM schrieb Petr Vorel:
> Hi all,
> 
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> 
> @Joerg I plan to merge this, can I add your Reviewed-by tag?
Sure:
Reviewed-by: Joerg Vehlow <joerg.vehlow@aox.de>


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] open_posix_testsuite: Replace old -W commandline argument

[Petr Vorel]

Hi all,

thanks for your time, merged.

@Detlef FYI added your Signed-off-by: tag, Cyril's Suggested-by: tag
and Fixes: tag.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] open_posix_testsuite: Replace old -W commandline argument

[Petr Vorel]

Hi,

>    Thanks all for your help and patience with a LTP newbie.

yw :).

>    Now, OpenWatcom (with my patched owcc frontend) passes >1100 tests
>    and more work on the OpenWatcom POSIX runtime can be done

Always interested to see who is using LTP.

>    (a big OW issue: "aio.h" and the related implementation is missing)

glibc and musl IMHO support aio.h unconditionally.  If you're using uclibc or
uclibc-ng, you need UCLIBC_HAS_REALTIME [1]. But below you mentioned glibc.

Kind regards,
Petr

[1] https://cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/tree/extra/Configs/Config.in#n1166

>    ---
>    Testing with another Compiler on my system:
>    Using the Open Posix Testsuite with TinyC and the system installed glibc
>    gives one failed test.
>    This is the same result as using gcc.

>    -----
>    When someone has a working setup for "git-send-email" with "[1]web.de",
>    please let me know.
>    (I tried git-imap-send as fallback, but that only creates the draft mail.
>    A web login into the [2]web.de mail interface
>    with editing the draft mail and manually sending the patch
>    is needed afterwards)

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp