public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Yang Xu <xuyang2018.jy@fujitsu.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] getsockopt01: Add case for errno EINVAL
Date: Thu, 16 May 2024 03:39:45 +0200	[thread overview]
Message-ID: <20240516013945.GD260285@pevik> (raw)
In-Reply-To: <20240516013427.GC260285@pevik>

Hi Xu,

> Hi Xu,

> ...
> > +++ b/testcases/kernel/syscalls/getsockopt/getsockopt01.c
> > @@ -15,6 +15,7 @@
> >   * - ENOTSOCK on a file descriptor not linked to a socket
> >   * - EFAULT on invalid address of value or length
> >   * - EOPNOTSUPP on invalid option name or protocol
> > + * - EINVAL on an invalid optlen
> >   */

> >  #include "tst_test.h"
> > @@ -24,6 +25,7 @@ static struct sockaddr_in sin0;
> >  static int sinlen;
> >  static int optval;
> >  static socklen_t optlen;
> > +static socklen_t optleninval;

> Again, -1 should be added here (can be fixed before merge):

Merged with this fix. Thanks!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2024-05-16  1:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-22  8:36 [LTP] [PATCH] getsockopt01: Add case for errno EINVAL Yang Xu via ltp
2024-05-16  1:34 ` Petr Vorel
2024-05-16  1:39   ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240516013945.GD260285@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=xuyang2018.jy@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox