Re: [LTP] [PATCH v1 01/10] Add SAFE_STATX macro

Petr Vorel
2024-05-16T14:50:10Z

> Hi,

> On 5/16/24 03:30, Petr Vorel wrote:
> > Hi Andrea,

> > could you please fix these?
> Sure

> > testcases/kernel/syscalls/statmount/statmount03.c: useless tag: format_device
> > testcases/kernel/syscalls/statmount/statmount03.c: useless tag: needs_tmpdir
> > testcases/kernel/syscalls/statmount/statmount03.c: useless tag: needs_tmpdir
> > testcases/kernel/syscalls/statmount/statmount03.c: useless tag: needs_tmpdir
> > testcases/kernel/syscalls/statmount/statmount04.c: useless tag: format_device
> > testcases/kernel/syscalls/statmount/statmount04.c: useless tag: needs_tmpdir
> > testcases/kernel/syscalls/statmount/statmount04.c: useless tag: needs_tmpdir
> > testcases/kernel/syscalls/statmount/statmount04.c: useless tag: needs_tmpdir
> > testcases/kernel/syscalls/statmount/statmount05.c: useless tag: format_device
> > testcases/kernel/syscalls/statmount/statmount05.c: useless tag: needs_tmpdir
> > testcases/kernel/syscalls/statmount/statmount05.c: useless tag: needs_tmpdir
> > testcases/kernel/syscalls/statmount/statmount05.c: useless tag: needs_tmpdir
> > testcases/kernel/syscalls/statmount/statmount06.c: useless tag: format_device

> > > diff --git a/include/tst_safe_macros.h b/include/tst_safe_macros.h
> > > index 8de8ef106..43ff50a33 100644
> > > --- a/include/tst_safe_macros.h
> > > +++ b/include/tst_safe_macros.h
> > > @@ -503,4 +503,11 @@ int safe_sscanf(const char *file, const int lineno, const char *restrict buffer,
> > > #define SAFE_SSCANF(buffer, format, ...) \
> > > safe_sscanf(__FILE__, __LINE__, (buffer), (format), ##__VA_ARGS__)
> > > +struct statx;
> > Could you please remove this? (unneeded)
> That's needed because in some distro statx is not defined before reaching
> that line causing build failure.

<sys/stat.h> are included in lapi/stat.h. I wonder if <linux/stat.h> would fail.

If the definition later works it should be fixable by including the needed
header in lapi/stat.h, right?

Could you post link to CI job which failed?

Kind regards,
Petr

> > With that, you might add for this patch in the next version:

> > Reviewed-by: Petr Vorel <pvorel@suse.cz>

> > Kind regards,
> > Petr

> Andrea