From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/2] lib: Add TINFO_WARN
Date: Tue, 28 May 2024 14:14:44 +0200 [thread overview]
Message-ID: <20240528121444.GA435237@pevik> (raw)
In-Reply-To: <20240528120554.433874-2-pvorel@suse.cz>
Hi,
I'm sorry to send this patchset twice (I forget I sent it a day before).
> When replaced tst_res(TINFO, "WARNING: ...") with tst_res(TINFO_WARN,
> "..."), then:
> - output message is magenta (the same as for TWARN => more visible),
> - "WARNING" is printed by the library (unification),
Also, Andrea suggested on the first patchset:
https://lore.kernel.org/ltp/37603272-8ea2-4828-96df-4b6381cc26ad@suse.com/
I'm not sure about this. Why not enabling TINFO + TWARN combination instead?
tst_res(TINFO | TWARN, "my message");
This actually makes sense => v2 needed.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-05-28 12:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 12:05 [LTP] [PATCH 0/2] lib: Add TINFO_WARN Petr Vorel
2024-05-28 12:05 ` [LTP] [PATCH 1/2] " Petr Vorel
2024-05-28 12:14 ` Petr Vorel [this message]
2024-05-28 12:05 ` [LTP] [PATCH 2/2] tree: Use TINFO_WARN Petr Vorel
-- strict thread matches above, loose matches on Subject: below --
2024-05-27 22:29 [LTP] [PATCH 0/2] lib: Add TINFO_WARN Petr Vorel
2024-05-27 22:29 ` [LTP] [PATCH 1/2] " Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240528121444.GA435237@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox