Re: [LTP] [PATCH] kvm_pagefault01: Do not write into tdp_mmu sysfile

[Petr Vorel <pvorel@suse.cz>]

Hi Martin, Jan,

> On Tue, May 28, 2024 at 11:38 AM Petr Vorel <pvorel@suse.cz> wrote:

> > > On 28. 05. 24 0:35, Petr Vorel wrote:
> > > > > +
> > > > > + if (read_bool_sys_param(TDP_MMU_SYSFILE) > 0)
> > > > > +         tst_res(TINFO, "tdp_mmu is enabled, beware of false negatives");

> > > > Wouldn't it be better to add "WARNING:" to make it more visible?
> > > >             tst_res(TINFO, "WARNING: tdp_mmu is enabled, beware of false negatives");

> > > > (if you agree, I can change it before merge)

> > > I thought about it for a while and I see good reasons for both TINFO and
> > > TWARN. It shouldn't matter for our tests because tdp_mmu defaults to off on
> > > SLE-15SP4 and SLE-15SP5. If other reviewers agree, feel free to change it to
> > > TWARN.

> > I slightly prefer tst_res(TINFO, "WARNING: ...", than TWARN. Although false
> > negative is serious, still failing the test based on suspicion of false
> > positives is not good.

> > @Li, @Jan, @Metan: any opinion on it?

> I'd go with TINFO here, as you suggested.

Thanks a lot both!

Patchset merged (Jan, I did not dare to add your RBT or ABT as you did not add
it), with added WARNING: (as Martin agreed).

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp