Re: [LTP] [PATCH] Fix unlink09 test

[Petr Vorel <pvorel@suse.cz>]

> On 05. 06. 24 14:27, Petr Vorel wrote:
> > Hi Martin,

> > Also I wonder if having functionality for .all_filesystems + .needs_rofs
> > wouldn't be useful. @Cyril @Martin WDYT?

> > Also, there is fallback when prepare_and_mount_ro_fs() fails to use block
> > device. Although, I don't see the read only mount flags added in this fallback,
> > IMHO MS_RDONLY is only in prepare_and_mount_ro_fs(), therefore the fallback is
> > read write and we even didn't get TWARN, just plain TINFO (it should be either
> > TWARN or TINFO with "WARNING:" at least).

> It would be useful and prepare_device() implements everything that's needed
> for it but there's a bug in do_setup() which creates a conflict between the
> two attributes. The .all_filesystems attribute forces .needs_device but a
> few lines below that is a check that .needs_rofs and .needs_device are not
> set at the same time. This can be fixed.

Thanks for info, I'll have look into it.

Anyway, you all agreed that splitting the test is needed either way.
And because of other thing Martin found (the third unfixed SAFE_OPEN() in
verify_unlink()) I'm setting this as changes requested.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp