From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0BB1C27C5E for ; Tue, 11 Jun 2024 11:02:27 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 001033D0B93 for ; Tue, 11 Jun 2024 13:02:25 +0200 (CEST) Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [217.194.8.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 88FBE3C0123 for ; Tue, 11 Jun 2024 13:02:11 +0200 (CEST) Authentication-Results: in-5.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=195.135.223.130; helo=smtp-out1.suse.de; envelope-from=pvorel@suse.cz; receiver=lists.linux.it) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id E0FC160FB3A for ; Tue, 11 Jun 2024 13:02:10 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9AD86336F0; Tue, 11 Jun 2024 11:02:09 +0000 (UTC) Authentication-Results: smtp-out1.suse.de; none Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 06F00137DF; Tue, 11 Jun 2024 11:02:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id t5fVNrAuaGaGEQAAD6G6ig (envelope-from ); Tue, 11 Jun 2024 11:02:08 +0000 Date: Tue, 11 Jun 2024 13:02:03 +0200 From: Petr Vorel To: Martin Doucha Message-ID: <20240611110203.GA34462@pevik> References: <20240603123455.7968-1-chrubis@suse.cz> <20240603123455.7968-2-chrubis@suse.cz> <85b362c0-9126-45cb-90af-9fe09b848661@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <85b362c0-9126-45cb-90af-9fe09b848661@suse.cz> X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Rspamd-Queue-Id: 9AD86336F0 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Virus-Scanned: clamav-milter 1.0.3 at in-5.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 1/2] lib: tst_test: Add per filesystem mkfs and mount opts X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Martin, Cyril, > Hi, > a design note below. ... > > + * @fss: A NULL type terminated array of per file system type options. If > > + * tst_test.all_filesystems is not set the array describes a list of > > + * file systems to test along with parameters to pass to mkfs and mount. > > + * If tst_test.all_filesystems is set the mkfs and mount options are > > + * taken from tst_test.fs unless there is an override for a given > > + * file system type defined in this array. > I like the general idea but I don't see the point of having separate .fs and > .fss. You could simply use .fss[0] for the same purpose as .fs. Look at the second patch where it is used (quotactl08.c): static struct tst_test test = { ... .fs = { .mkfs_opts = (const char *const[]){ "-O quota", NULL }, .type = "ext4", }, So would you set it as array? static struct tst_test test = { ... .fss = (struct tst_fs[]){ { .mkfs_opts = (const char *const[]){ "-O quota", NULL }, .type = "ext4", }, {} }, It's a bit verbose, but maybe having separate .fs is slightly more confusing. Also having only array, we could use .fs name for it. Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp