From: Li Wang <liwang@redhat.com>
To: ltp@lists.linux.it, pvorel@suse.cz
Subject: [LTP] [PATCH] tst_kconfig: Avoid buffer overflow when parsing /proc/cmdline
Date: Wed, 19 Jun 2024 15:33:45 +0800 [thread overview]
Message-ID: <20240619073345.326108-1-liwang@redhat.com> (raw)
When the test is run with a kernel booting with many parameters, the
buffer size is often not large enough to store the complete command
line. This results in a buffer overflow and the test complains with
the following message:
tst_kconfig.c:609: TWARN: Buffer overflowed while parsing /proc/cmdline
Signed-off-by: Li Wang <liwang@redhat.com>
---
lib/tst_kconfig.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/tst_kconfig.c b/lib/tst_kconfig.c
index e16ca1400..be3842c2d 100644
--- a/lib/tst_kconfig.c
+++ b/lib/tst_kconfig.c
@@ -569,7 +569,7 @@ char tst_kconfig_get(const char *confname)
void tst_kcmdline_parse(struct tst_kcmdline_var params[], size_t params_len)
{
- char buf[128], line[512];
+ char buf[512], line[512];
size_t b_pos = 0,l_pos =0, i;
int var_id = -1;
--
2.45.2
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next reply other threads:[~2024-06-19 7:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 7:33 Li Wang [this message]
2024-06-19 7:47 ` [LTP] [PATCH] tst_kconfig: Avoid buffer overflow when parsing /proc/cmdline Petr Vorel
2024-06-19 10:20 ` Li Wang
2024-06-19 13:30 ` Petr Vorel
2024-06-20 1:45 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240619073345.326108-1-liwang@redhat.com \
--to=liwang@redhat.com \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox