public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Wei Gao <wegao@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 2/2] Add unlink10 test
Date: Wed, 19 Jun 2024 18:05:36 +0200	[thread overview]
Message-ID: <20240619160536.GB477172@pevik> (raw)
In-Reply-To: <ZmI/U99dR9MC2HKF@wegao.75.89.121>

Hi Andrea, Wei,

> > This test verifies that unlink(2) fails with EROFS when target file
> > is on a read-only filesystem.

Test LGTM, but I would prefer to merge it together with unlink09.c change (first
patch).

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2024-06-19 16:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-05 14:40 [LTP] [PATCH v2 0/2] Fix unlink09 test Andrea Cervesato
2024-06-05 14:40 ` [LTP] [PATCH v2 1/2] " Andrea Cervesato
2024-06-19 15:50   ` Petr Vorel
2024-06-05 14:40 ` [LTP] [PATCH v2 2/2] Add unlink10 test Andrea Cervesato
2024-06-06 22:10   ` Wei Gao via ltp
2024-06-06 22:59   ` Wei Gao via ltp
2024-06-19 16:05     ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240619160536.GB477172@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=wegao@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox