From: Edward Liaw via ltp <ltp@lists.linux.it>
To: ltp@lists.linux.it
Cc: kernel-team@android.com
Subject: [LTP] [PATCH v5 1/2] sched/starvation: Fix sched_setaffinity return check
Date: Wed, 19 Jun 2024 16:28:06 +0000 [thread overview]
Message-ID: <20240619162807.2725018-2-edliaw@google.com> (raw)
In-Reply-To: <20240619162807.2725018-1-edliaw@google.com>
From: Edward Liaw via ltp <ltp@lists.linux.it>
TST_EXP_POSITIVE to check the return value is incorrect because
sched_setaffinity returns 0 on success / -1 on failure.
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
Signed-off-by: Edward Liaw <edliaw@google.com>
---
testcases/kernel/sched/cfs-scheduler/starvation.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/testcases/kernel/sched/cfs-scheduler/starvation.c b/testcases/kernel/sched/cfs-scheduler/starvation.c
index eb9fd6ff5..c845af849 100644
--- a/testcases/kernel/sched/cfs-scheduler/starvation.c
+++ b/testcases/kernel/sched/cfs-scheduler/starvation.c
@@ -54,7 +54,8 @@ static void setup(void)
CPU_SET(0, &mask);
- TST_EXP_POSITIVE(sched_setaffinity(0, sizeof(mask), &mask));
+ if (sched_setaffinity(0, sizeof(mask), &mask) < 0)
+ tst_brk(TBROK | TERRNO, "sched_setaffinity() failed");
if (tst_parse_long(str_loop, &loop, 1, LONG_MAX))
tst_brk(TBROK, "Invalid number of loop number '%s'", str_loop);
--
2.45.2.627.g7a2c4fd464-goog
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-06-19 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 16:28 [LTP] [PATCH v5 0/2] sched/starvation: Choose from available cpus Edward Liaw via ltp
2024-06-19 16:28 ` Edward Liaw via ltp [this message]
2024-06-19 16:28 ` [LTP] [PATCH v5 2/2] " Edward Liaw via ltp
2024-06-19 17:50 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240619162807.2725018-2-edliaw@google.com \
--to=ltp@lists.linux.it \
--cc=edliaw@google.com \
--cc=kernel-team@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox