From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19E40C27C53 for ; Thu, 20 Jun 2024 02:17:03 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 4A2D33D0DE1 for ; Thu, 20 Jun 2024 04:17:02 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 718D53C006F for ; Thu, 20 Jun 2024 04:16:47 +0200 (CEST) Authentication-Results: in-3.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=liwang@redhat.com; receiver=lists.linux.it) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id CD4DB1A00806 for ; Thu, 20 Jun 2024 04:16:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718849805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qN2PChEZPNxcg07mmPX90L9wMoJIXViO8M2375NnOtQ=; b=UyYdkxcA6c0SkSADDMa9Be+hWoTLkq5ruR7x9Y4IW9V1eiWhB+p/Pt6CQnTr0D9/y9IT65 bnrDZuN02fgQG7yZbcQVn1EgpIAIiZTuOLSu5pC+8DnVPiFJgh44lVaKwrqiY3ta8lIboh eiagQuAB+xvGiMYVryxFZO4Qc5F9Qwo= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-437-y2b8QHqUOlGeWD1cuI1Osg-1; Wed, 19 Jun 2024 22:16:43 -0400 X-MC-Unique: y2b8QHqUOlGeWD1cuI1Osg-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8AE4C195609F; Thu, 20 Jun 2024 02:16:42 +0000 (UTC) Received: from dell-per7425-02.rhts.eng.pek2.redhat.com (dell-per7425-02.rhts.eng.pek2.redhat.com [10.73.116.18]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9E5851956048; Thu, 20 Jun 2024 02:16:39 +0000 (UTC) From: Li Wang To: ltp@lists.linux.it, pvorel@suse.cz Date: Thu, 20 Jun 2024 10:16:35 +0800 Message-ID: <20240620021635.489505-1-liwang@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Virus-Scanned: clamav-milter 1.0.3 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: [LTP] [PATCH v2] tst_kconfig: Avoid reporting buffer overflow when parsing /proc/cmdline X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" When the test is run with a kernel booting with many parameters, the buffer size is often not large enough to store the complete command line. This results in a buffer overflow and the test complains with the following message: tst_kconfig.c:609: TWARN: Buffer overflowed while parsing /proc/cmdline Note: Petr point out that these configs, which are generated by toolchain will be longer than 128 chars someday, but I don't think that is the reason we need raise our parsed buffer, since tst_kcmdline_parse() was just add for popular parameter (which always pass by user and short). So far I don't see any LTP test parse a longer parameters. Fixes: 180834982 ("kconfig: add funtion to parse /proc/cmdline") Signed-off-by: Li Wang Cc: Petr Vorel --- include/tst_kconfig.h | 2 +- lib/tst_kconfig.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/tst_kconfig.h b/include/tst_kconfig.h index dcb370574..23f807409 100644 --- a/include/tst_kconfig.h +++ b/include/tst_kconfig.h @@ -87,7 +87,7 @@ int tst_kconfig_check(const char *const kconfigs[]); */ struct tst_kcmdline_var { const char *key; - char value[128]; + char value[256]; bool found; }; diff --git a/lib/tst_kconfig.c b/lib/tst_kconfig.c index e16ca1400..8eb1b803f 100644 --- a/lib/tst_kconfig.c +++ b/lib/tst_kconfig.c @@ -569,7 +569,7 @@ char tst_kconfig_get(const char *confname) void tst_kcmdline_parse(struct tst_kcmdline_var params[], size_t params_len) { - char buf[128], line[512]; + char buf[256], line[512]; size_t b_pos = 0,l_pos =0, i; int var_id = -1; @@ -606,7 +606,7 @@ void tst_kcmdline_parse(struct tst_kcmdline_var params[], size_t params_len) break; default: if (b_pos + 1 >= sizeof(buf)) { - tst_res(TWARN, "Buffer overflowed while parsing /proc/cmdline"); + tst_res(TINFO, "Buffer overflowed while parsing /proc/cmdline"); while (line[l_pos] != '\0' && line[l_pos] != ' ' && line[l_pos] != '\n') l_pos++; -- 2.45.2 -- Mailing list info: https://lists.linux.it/listinfo/ltp