public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] lib: tst_fd: Add kernel version check to memfd_secret
Date: Fri, 21 Jun 2024 13:09:24 +0200	[thread overview]
Message-ID: <20240621110924.GA672386@pevik> (raw)
In-Reply-To: <1718700544-17304-1-git-send-email-nobuhiro1.iwamatsu@toshiba.co.jp>

Hi Nobuhiro,

> memfd_secret is a syscall added since 5.14. On earlier kernels, tests such
> as accept03, readahead01 and splice07 that use memfd_secret fail.
> This adds a kernel version check to the tst_fd library when running tests using
> memfd_secret.

Cyril's suggestion to add fallback definitions sounds to me as a good idea:

https://lore.kernel.org/ltp/ZnVCcU6jOU98DYek@yuki/

	I guess that the best fix is to add fallback definitions for
	memfd_secret into include/lapi/syscalls/*.in files. That way we should
	get -1 and EINVAL properly even when kernel does not support the
	syscall.

Could you please try that first?

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2024-06-21 11:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-18  8:49 [LTP] [PATCH] lib: tst_fd: Add kernel version check to memfd_secret Nobuhiro Iwamatsu
2024-06-18 10:15 ` Cyril Hrubis
2024-06-19  5:24   ` nobuhiro1.iwamatsu
2024-06-19 17:33     ` Petr Vorel
2024-06-20  1:22       ` nobuhiro1.iwamatsu
2024-06-20 13:25         ` Petr Vorel
2024-06-21  9:07           ` Cyril Hrubis
2024-06-21  9:05     ` Cyril Hrubis
2024-06-21 11:09 ` Petr Vorel [this message]
2024-06-28  8:40   ` nobuhiro1.iwamatsu
2024-07-12 18:40     ` Edward Liaw via ltp
2024-07-16  4:25       ` nobuhiro1.iwamatsu
  -- strict thread matches above, loose matches on Subject: below --
2024-06-18  9:09 Nobuhiro Iwamatsu
2024-06-21 11:13 ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240621110924.GA672386@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=nobuhiro1.iwamatsu@toshiba.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox