[LTP] [PATCH v2 1/6] sched_football: Drop use of sched_yeild()

John Stultz via ltp
2024-06-25T23:53:24Z

sched_yeild() just causes the SCHED_FIFO tasks to behave like
SCHED_RR which makes analysis of the behavior more difficult to
follow. So lets drop the calls.

Also fixes up some whitespace inconsistencies in the header comment.

Cc: kernel-team@android.com
Cc: Cyril Hrubis <chrubis@suse.cz>
Cc: Darren Hart <darren@os.amperecomputing.com>
Signed-off-by: John Stultz <jstultz@google.com>
---
.../realtime/func/sched_football/sched_football.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/testcases/realtime/func/sched_football/sched_football.c b/testcases/realtime/func/sched_football/sched_football.c
index 6f075aea3..1e205219d 100644
--- a/testcases/realtime/func/sched_football/sched_football.c
+++ b/testcases/realtime/func/sched_football/sched_football.c
@@ -32,12 +32,12 @@
* - Create a fixed number of offense threads (lower priority)
* - Create a referee thread (highest priority)
* - Once everyone is on the field, the offense thread increments the
- * value of 'the_ball' and yields. The defense thread tries to block
- * the ball by never letting the offense players get the CPU (it just
- * does a sched_yield).
+ * value of 'the_ball'. The defense thread tries to block
+ * the ball by never letting the offense players get the CPU (it just
+ * spins).
* - The refree threads wakes up regularly to check if the game is over :)
* - In the end, if the value of 'the_ball' is >0, the test is considered
- * to have failed.
+ * to have failed.
*
* USAGE:
* Use run_auto.sh script in current directory to build and run test.
@@ -113,7 +113,6 @@ void *thread_defense(void *arg)
atomic_inc(&players_ready);
/*keep the ball from being moved */
while (1) {
- sched_yield(); /* let other defenders run */
}
return NULL;
}
@@ -124,7 +123,6 @@ void *thread_offense(void *arg)
atomic_inc(&players_ready);
while (1) {
the_ball++; /* move the ball ahead one yard */
- sched_yield(); /* let other offensive players run */
}
return NULL;