[LTP] [PATCH] build.sh: delete outdated SKIP_IDCHECK parameter

[LTP] [PATCH] build.sh: delete outdated SKIP_IDCHECK parameter

[Jiwei Sun]

From: Jiwei Sun <sunjw10@lenovo.com>

Commit 1accb3e03ec37 ("Makefile: Remove IDcheck.sh") removed the
parameter SKIP_IDCHECK. Remove it from build.sh and INSTALL in order
to avoid confusion.

Reviewed-by: Adrian Huang <ahuang12@lenovo.com>
Signed-off-by: Jiwei Sun <sunjw10@lenovo.com>
---
 INSTALL  | 6 ------
 build.sh | 2 +-
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/INSTALL b/INSTALL
index 99386bed8..dd57f6a38 100644
--- a/INSTALL
+++ b/INSTALL
@@ -55,13 +55,10 @@ in the same directory where the source files reside.
 	$ make all
 	$ make \
 	  "DESTDIR=$SYSROOT" \
-	  SKIP_IDCHECK=[0|1] \
 	  install
 
 - Specifying DESTDIR is optional, but required when installing to a non-host
   sysroot, as opposed to the host system's sysroot.
-- Specify SKIP_IDCHECK=1 if and when you don't want to modify /etc/{group,passwd}
-  on the target system's sysroot.
 
 If you get a build error, please report it to ltp@lists.linux.it with
 following information,
@@ -95,13 +92,10 @@ items which need fixing in the LTP tree.
 	  "top_srcdir=$TOP_SRCDIR" \
 	  "top_builddir=$OUT_OF_BUILD_TREE_DIR" \
 	  "DESTDIR=$SYSROOT" \
-	  SKIP_IDCHECK=[0|1]
 	  install
 
 - Specifying DESTDIR is optional, but required when installing to a non-host
   sysroot, as opposed to the host system's sysroot.
-- Specify SKIP_IDCHECK=1 if and when you don't want to modify /etc/{group,passwd}
-  on the target system's sysroot.
 
 Quick Start
 -----------
diff --git a/build.sh b/build.sh
index 1767cc21b..7bd0d3859 100755
--- a/build.sh
+++ b/build.sh
@@ -138,7 +138,7 @@ install_in_tree()
 install_out_tree()
 {
 	cd $BUILD_DIR
-	make $MAKE_OPTS_OUT_TREE DESTDIR="$prefix" SKIP_IDCHECK=1 install
+	make $MAKE_OPTS_OUT_TREE DESTDIR="$prefix" install
 }
 
 usage()
-- 
2.27.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] build.sh: delete outdated SKIP_IDCHECK parameter

[Li Wang]

On Thu, Jul 4, 2024 at 1:40 PM Jiwei Sun <sunjw10@outlook.com> wrote:

> From: Jiwei Sun <sunjw10@lenovo.com>
>
> Commit 1accb3e03ec37 ("Makefile: Remove IDcheck.sh") removed the
> parameter SKIP_IDCHECK. Remove it from build.sh and INSTALL in order
> to avoid confusion.
>
> Reviewed-by: Adrian Huang <ahuang12@lenovo.com>
> Signed-off-by: Jiwei Sun <sunjw10@lenovo.com>
>

Reviewed-by: Li Wang <liwang@redhat.com>

---
>  INSTALL  | 6 ------
>  build.sh | 2 +-
>  2 files changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/INSTALL b/INSTALL
> index 99386bed8..dd57f6a38 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -55,13 +55,10 @@ in the same directory where the source files reside.
>         $ make all
>         $ make \
>           "DESTDIR=$SYSROOT" \
> -         SKIP_IDCHECK=[0|1] \
>           install
>
>  - Specifying DESTDIR is optional, but required when installing to a
> non-host
>    sysroot, as opposed to the host system's sysroot.
> -- Specify SKIP_IDCHECK=1 if and when you don't want to modify
> /etc/{group,passwd}
> -  on the target system's sysroot.
>
>  If you get a build error, please report it to ltp@lists.linux.it with
>  following information,
> @@ -95,13 +92,10 @@ items which need fixing in the LTP tree.
>           "top_srcdir=$TOP_SRCDIR" \
>           "top_builddir=$OUT_OF_BUILD_TREE_DIR" \
>           "DESTDIR=$SYSROOT" \
> -         SKIP_IDCHECK=[0|1]
>           install
>
>  - Specifying DESTDIR is optional, but required when installing to a
> non-host
>    sysroot, as opposed to the host system's sysroot.
> -- Specify SKIP_IDCHECK=1 if and when you don't want to modify
> /etc/{group,passwd}
> -  on the target system's sysroot.
>
>  Quick Start
>  -----------
> diff --git a/build.sh b/build.sh
> index 1767cc21b..7bd0d3859 100755
> --- a/build.sh
> +++ b/build.sh
> @@ -138,7 +138,7 @@ install_in_tree()
>  install_out_tree()
>  {
>         cd $BUILD_DIR
> -       make $MAKE_OPTS_OUT_TREE DESTDIR="$prefix" SKIP_IDCHECK=1 install
> +       make $MAKE_OPTS_OUT_TREE DESTDIR="$prefix" install
>  }
>
>  usage()
> --
> 2.27.0
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
>
>

-- 
Regards,
Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH] build.sh: delete outdated SKIP_IDCHECK parameter

[Petr Vorel]

Hi Jiwei, all,

thanks for fixing my error, merged!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp