From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A51AC3DA42 for ; Wed, 10 Jul 2024 14:44:29 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 8A4FC3D3874 for ; Wed, 10 Jul 2024 16:44:27 +0200 (CEST) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [IPv6:2001:4b78:1:20::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id EB0453D3856 for ; Wed, 10 Jul 2024 16:44:12 +0200 (CEST) Authentication-Results: in-7.smtp.seeweb.it; spf=pass (sender SPF authorized) smtp.mailfrom=suse.cz (client-ip=2a07:de40:b251:101:10:150:64:2; helo=smtp-out2.suse.de; envelope-from=pvorel@suse.cz; receiver=lists.linux.it) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 75838206C57 for ; Wed, 10 Jul 2024 16:44:11 +0200 (CEST) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5EFC01F836; Wed, 10 Jul 2024 14:44:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1720622650; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zXY72LJbsJRW9CbgwzxSiBg/ZJ3suk08i8HlG+CEJi8=; b=sgBGwuWxQ+ezdUcVOS5A/Aag0DQKegCMudQesHZ9Wl7n/dv4xB2lUJuTEsYU23aaALaQbm YsgW+w4ka78p3YQEkIupXzZrkKbBS2WsVUfgIbEYJiGmtZIyRxeJak4IoITnaCB0Vdp9Oj Y8f+ybg/SJ51tcNSSafoRNY/MwBgcm0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1720622650; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zXY72LJbsJRW9CbgwzxSiBg/ZJ3suk08i8HlG+CEJi8=; b=IYPKNiCnlz1JCuWviefp7n3g5wM0d+xTtapnCGMGIG9acGt14GqDyGnRtl92ZZjqbak8VK dYjAQ7Q9qIqe/aAg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1720622649; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zXY72LJbsJRW9CbgwzxSiBg/ZJ3suk08i8HlG+CEJi8=; b=Lb4q2PVF/uATuxtfZk7jIHhb6MkERuCguwT9aYoVqbZ2RGDJkpe/ECr+O1tEh9pljzmiJg rdH2n9hMDxxXJJ06O5VNmqho1tNGQYXw1gvyde1bH5rMOhRtlynv+w74M0Hkgul//SKQJa mVSYDy4zPoufp5xB0PHfDPR15IUlD2k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1720622649; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zXY72LJbsJRW9CbgwzxSiBg/ZJ3suk08i8HlG+CEJi8=; b=B3f5jUTBe3yApqXelvXUFjP8/TiYlulodYm/w4997bnEIdAwCmbhEznQ835TT04XB0fCmC 00zjJeA93p3jVuDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 428881369A; Wed, 10 Jul 2024 14:44:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id sqqzDjmejmY8QQAAD6G6ig (envelope-from ); Wed, 10 Jul 2024 14:44:09 +0000 Date: Wed, 10 Jul 2024 16:44:03 +0200 From: Petr Vorel To: Andrea Cervesato Message-ID: <20240710144403.GA295483@pevik> References: <20240710-stat04-v3-0-c68a2324ad94@suse.com> <20240710-stat04-v3-1-c68a2324ad94@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240710-stat04-v3-1-c68a2324ad94@suse.com> X-Spamd-Result: default: False [-7.50 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; HAS_REPLYTO(0.30)[pvorel@suse.cz]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; RCPT_COUNT_THREE(0.00)[4]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.cz:replyto]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; REPLYTO_EQ_FROM(0.00)[] X-Virus-Scanned: clamav-milter 1.0.3 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v3 1/4] Add stat04 test X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Andrea, > +static void cleanup(void) > +{ > + if (tmpdir) > + free(tmpdir); > + > + if (access(SYMBNAME, F_OK) != -1) > + SAFE_UNLINK(SYMBNAME); nit: I would remove this (not needed). + Cyril's note about using asprintf(), hopefully v4 will be merged. Thanks! Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp