From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 3/4] Add chmod08 test
Date: Wed, 10 Jul 2024 17:12:01 +0200 [thread overview]
Message-ID: <20240710151201.GA297440@pevik> (raw)
In-Reply-To: <20240710-stat04-v3-3-c68a2324ad94@suse.com>
Hi Andrea,
Reviewed-by: Petr Vorel <pvorel@suse.cz>
thanks a lot, merged with tiny changes.
> +++ b/testcases/kernel/syscalls/chmod/chmod08.c
> @@ -0,0 +1,45 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Copyright (c) 2000 Silicon Graphics, Inc. All Rights Reserved.
> + * Author: David Fenner
> + * Copilot: Jon Hendrickson
> + * Copyright (C) 2024 Andrea Cervesato andrea.cervesato@suse.com
very nit: <andrea.cervesato@suse.com> (missing < >). Added.
> + */
> +
> +/*\
> + * [Description]
> + *
> + * This test verifies that chmod() is working correctly on symlink()
> + * generated files.
> + */
> +
> +#include "tst_test.h"
> +
> +#define PERMS 01777
> +#define TESTFILE "myobject"
> +#define SYMBNAME "my_symlink0"
Very nit: you mix tabs and spaces as a separator after define. Fixed.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-07-10 15:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 8:54 [LTP] [PATCH v3 0/4] symlink01 split Andrea Cervesato
2024-07-10 8:54 ` [LTP] [PATCH v3 1/4] Add stat04 test Andrea Cervesato
2024-07-10 12:15 ` Cyril Hrubis
2024-07-10 14:44 ` Petr Vorel
2024-07-10 15:14 ` Petr Vorel
2024-07-10 8:54 ` [LTP] [PATCH v3 2/4] Add lstat03 test Andrea Cervesato
2024-07-10 14:53 ` Petr Vorel
2024-07-10 8:54 ` [LTP] [PATCH v3 3/4] Add chmod08 test Andrea Cervesato
2024-07-10 15:12 ` Petr Vorel [this message]
2024-07-10 8:54 ` [LTP] [PATCH v3 4/4] Add open15 test Andrea Cervesato
2024-07-10 9:37 ` Li Wang
2024-07-10 14:39 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240710151201.GA297440@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox