From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: mataotao <mataotao@uniontech.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] shell: add echo command check
Date: Wed, 10 Jul 2024 17:32:41 +0200 [thread overview]
Message-ID: <20240710153241.GA300319@pevik> (raw)
In-Reply-To: <CAEemH2eFmg7CUwLhA97O22cvdxKks7yy4cPcCx_uE6mg3GYjtg@mail.gmail.com>
Hi Mataotao,
> Hi Mataotao,
> First, thank you for creating new tests for LTP.
Thank you!
> But from what I know LTP now is mainly a face-to-Linux Kernel side test
> suite,
> rather than the userspace or command line test (it had some but slowly being
> removed from the test suite).
+1, these would be better placed in coreutils or the shell project you target.
> 'echo' is daily popular used but belongs to the coreutils package, it's not
> the core
Also, 'echo' is not only binary from coreutils, but also a shell builtin.
Moreover, 'echo' is known for various incompatibility across implementations
(printf is suggested to be used if compatibility is needed).
Kind regards,
Petr
> of kernel part. I guess maintainers have no passion for reviewing patch
> like this:(.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-07-10 15:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 7:17 [LTP] [PATCH] shell: add echo command check mataotao
2024-06-24 7:54 ` Li Wang
2024-07-10 15:32 ` Petr Vorel [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-05-28 10:13 mataotao
2024-05-28 9:56 mataotao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240710153241.GA300319@pevik \
--to=pvorel@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
--cc=mataotao@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox