Re: [LTP] [RFC PATCH 1/2] Add support for mixing C and shell code

[Petr Vorel <pvorel@suse.cz>]

> Hi!
> > > This is a proof of a concept of a seamless C and shell integration. The
> > > idea is that with this you can mix shell and C code as much as as you
> > > wish to get the best of the two worlds.

> > > Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> > > ---
> > >  include/tst_test.h                           | 38 +++++++++++++
> > >  lib/tst_test.c                               | 51 +++++++++++++++++
> > >  testcases/lib/.gitignore                     |  1 +
> > >  testcases/lib/Makefile                       |  4 +-
> > >  testcases/lib/run_tests.sh                   | 10 ++++
> > >  testcases/lib/tests/.gitignore               |  6 ++
> > >  testcases/lib/tests/Makefile                 | 11 ++++
> > >  testcases/lib/tests/shell_loader.sh          |  5 ++
> > >  testcases/lib/tests/shell_test01.c           | 17 ++++++
> > >  testcases/lib/tests/shell_test02.c           | 18 ++++++
> > >  testcases/lib/tests/shell_test03.c           | 25 +++++++++
> > >  testcases/lib/tests/shell_test04.c           | 18 ++++++
> > >  testcases/lib/tests/shell_test05.c           | 27 +++++++++
> > >  testcases/lib/tests/shell_test06.c           | 16 ++++++
> > FYI we have shell tests for new library in lib/newlib_tests (C tests) and
> > lib/newlib_tests/shell/ (shell tests), is it necessary to add new location? Or,
> > if you prefer this, we should move existing tests from lib/newlib_tests/shell/
> > to this new location.

> For a historical reasons the lib for shell is in testcases/lib/ and the
> tests use paths to binaries and scripts in there so I added the code
> there. We may as well move it to the top level lib/shell, or create top
> level slib (as for shell lib) or anywhere else as long as we agree on a
> better place to put the code.

Yeah, we could move everything to lib/shell. I'm also OK with different location
with the tests, i.e. we can keep things where they are.

My main concern is to run the tests in CI and in 'make test' target (also
specify new subtest e.g. test-c-shell: or add them to test-c).

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp